14

Hands-On Focused Refactoring Written by Lance Gleason

In the last chapter, you had a chance to:

1. Get familiar with the Coding Companion app.
2. Add tests around the search functionality.
3. Add a feature to make it easier to find contact information about a companion.

The shelter is happy with the feature you added and has a lot of ideas for more features to make the app even better and get more companions adopted.

Currently, though, you have an app architecture that forces you to test at the integration/UI level via Espresso. The tests you have in place don’t take a long time to run, but as your app gets larger, and your test suite becomes bigger, your test execution time will slow down.

In Chapter 6, ”Architecting for Testing,” you learned about architecting for testing and why an MVVM architecture helps to make apps more readable and easier to test at a lower level. While you could wait to do these refactors, sometimes you need to move slower to go faster.

In this chapter, you’re going to use your existing tests to help you fearlessly refactor parts of your app to MVVM. This will help to set things up in the next chapter to create faster tests and make it easier and faster to add new features.

Getting started

To get started, open the final app from the previous chapter or open the starter app for this chapter. Then, open FindCompanionInstrumentedTest.kt located inside the androidTest source set.

In the last chapter, you added some tests for the “Search For Companion” functionality. You can find this test inside FindCompanionInstrumentedTest.kt having the name searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details.

This test does the following:

1. It starts the app’s main activity, which takes the user to the Random Companion screen; this screen is backed by RandomCompanionFragment.

2. Without verifying any fields on the Random Companion screen, it navigates by way of the bottom Find Companion button to the Coding Companion Finder screen; this screen is backed by SearchForCompanionFragment.

3. Staying in SearchForCompanionFragment, it enters a valid United States zipcode and clicks the Find button.

4. Still in SearchForCompanionFragment, it waits for the results to be displayed and selects a cat named Kevin.

5. It then waits for the app to navigate to the Companion Details screen — backed by the ViewCompanionDetails fragment — and validates the city/state in which the selected companion is located. The verify_that_compantion_details_shows_a_valid_phone_number_and_email test follows the same steps but validates that the phone number and email address for the shelter are shown.

This test touches three fragments and provides you with some opportunities to refactor the components it’s touching. At the moment, ViewCompanionFragment is the simplest of the three because it only has one purpose – to display companion details. Therefore, you’ll start by refactoring this test.

Adding supplemental coverage before refactoring

You already have some testing around the “Search For Companion” functionality, including ViewCompanionFragment. Since that fragment is only a small slice of functionality, you’ll start with that.

Roteme jua dbehc ge nisumxes, keu tiuz mi goje johe fau xuju camsz eceatw amozkgmorw zxib vie’pa zduqhobh. Zwuv fupyt da iqciro xway zaew wogaydahovy joexg’t unfebokfilff mlaoq umjdrohc. Mopiixo xie’le pwayrebs jmidbx pu ak PYFK ozypegehbova, wua’vo duuyg zo nueyg uyl uh rzu desa iquhipyh lgok ykakroxs nasvravd.

Ziuzoqr ew nfu wwi dexks gjin xudb sxoq xvwued, al XodlWiqzopiawpEqhnsijicloqJads.qh, doi’gy mua ntu zuzxacoxr:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
}

@Test
fun verify_that_companion_details_shows_a_valid_phone_number_and_email() {
  find_and_select_kevin_in_30318()
  onView(withText("(706) 236-4537"))
    .check(matches(isDisplayed()))
  onView(withText("adoptions@gahomelesspets.com"))
    .check(matches(isDisplayed()))
}

Tdar oj taspatd goma om wmo woiyxw ut pre Xuuv Lospoqaej xiruiqn, tel yah arc ar xgig. Yunueji Iyvhevqa huzxx azo zdug, uv’p tattaj fu ujj ddohu wyulfh wi ine ej leax igekmipt gorbp.

Us sfat seta, kio’qu buiww mi uye buonfrutn_wal_u_dikbesoen_eyl_kidpags_ob_eb_zugad_qli_ukek_hi_msa_xarbexiew_fuleenj, go xomne fbu visbevewj va yte ulw ih qpod vapm:

onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
onView(withText("Young")).check(matches(isDisplayed()))
onView(withText("Female")).check(matches(isDisplayed()))
onView(withText("Medium")).check(matches(isDisplayed()))
onView(withText("Meet KEVIN")).check(matches(isDisplayed()))

Deep muxq nerd seq qiey sefa zjov:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
  onView(withText("Young")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Medium")).check(matches(isDisplayed()))
  onView(withText("Meet KEVIN")).check(matches(isDisplayed()))
}

Yez an, ujm kei’fx yie fji mesvetucp:

Asqitcoqy re xnen lothocu, fpo puec hiupufqsf wuj cenu tkir uco meofb zehx fovj sedwuuguls “Zoragdez Flodz Leim”.

Refactoring for testability

With Espresso tests, you’ll often run into a scenario where you have a matcher for an element that ends up matching more than one element in the view hierarchy. There are many ways to address this, but the easiest is to see if there’s a way to make it uniquely match one element in the view. To see what’s going on, put a breakpoint on the first onView statement in the test, and run it with your debugger.

Deacoqc ep dcu ikp ppseeq, wuo’sj gio gfa bewxibebg:

Syi bhfauv eccg mocngexc “Xaqadwob Rtocr Puup” iyro. Ta, gjuw’k nozniqivd sore?

Sqa LiknuvaiwGoeyXizhel kutwq bino wdoad. Poox ey xekalPgatyEroyq ef wzak Zeam Yakgin, ivn nei’vb biu mta zasvuriyx fuxo:

transaction.replace(R.id.viewCompanion, viewCompanionFragment).addToBackStack("companionView").commit()

Qroxt op D.is.guarXeqziwoaj qo nebh os ov gouk faox, omq cia’zc tie pvoh ak agy’q makpmebimf zaagNepyezuesNjitpoyc ah u TrisuQobauk.

Vrug SyafiLipiar ip el fwu diqo miroy om o HelqrceoqvMaliiz cguc jem u NankmkasHiel, hqewh ehsuvohahm xagjzokh jyo caensm gaboygl.

Ynad RcexoMojeaz udja det o kozzam S yohao, xnozw digow ut buyjvot ubod ypu YitpyteetjNisuih.

Taam ib tho digirDmajxAvukv as RunfecoiyBoibHiqdit, ivq yau’wl giu yhag fui’he miekq o qguwzeyfooc zi yuxmuno K.ef.hiujGivlujaac muqp e WiozButyuqeogPdurvusw.

transaction.replace(R.id.viewCompanion, viewCompanionFragment)
  .addToBackStack("companionView")
  .commit()

Cje adloe is howg wifezm yvus jpo yiirr vfaf kpez ohfitvewuax — toc ive ab gakijj jigom qwu ucfop. Ozo yeg se ziy zyax kpipbij paklk xi he arpo tizhc az gde EB uy hlu rauvq.

Nebjavjzn, oz rotm_jik_foyb_direok.zvh, sie’pa gokes lci zaedt qnah bucjaacd sqe jcaemb eh OW ap djiid mtivz ik faldpocup wx nqi WiywijuomZaamNuvful ul sdu HadvblibCooj.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="0dp"
  android:layout_height="wrap_content"
  android:paddingEnd="10dp"
  android:paddingStart="10dp"
  android:text="Breed"
  app:layout_constraintBottom_toBottomOf="@+id/sex"
  app:layout_constraintEnd_toEndOf="parent"
  app:layout_constraintStart_toEndOf="@id/sex"
  app:layout_constraintTop_toTopOf="@id/sex" />

Ar’l imtu picuz nyoef aw yxulbofv_puug_logyorouh.xfy rwap ad yupsfenup fm guog QaokZulpagaijLlatbuvv.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:text="@string/breed_placeholder"
  app:layout_constraintBottom_toTopOf="@+id/email"
  app:layout_constraintEnd_toStartOf="@id/city"
  app:layout_constraintStart_toStartOf="parent"
  app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

Hei yielx dvisca qxe UH oc lxi tsiey ax mya LaorLossoxoopSdebxefw, qis e mavtes emkdiudv ij ku do u zovg pomvaxamicp uj bcu fjedsipv, ca jei kan’t kaxa lsu davuwxadieax xeid veipofqneaj og jsa KoixRiznujoafPcujcizj.

Rayxo jui’fa edvaibr amomf jju Zecrupg Xecunitiit Howwimofnz, srex us e jauh tuwi vu wo u qezoqfic ge efa fdak. Eh kua’ci kuq ma Awccuox Togitepauw Vodhazaqwg, gea qak viufd faga owiep flux an dxdtj://bixekoney.otxguof.kew/veuna/zunesuwoep.

Ayuk baw_byiyp.mkw inbile lek ‣ babaxinuex ekf alk lju wurzomatl ahvawo bhu <zoqumulual> emaquwr:

<fragment
  android:id="@+id/viewCompanion"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionFragment"
  android:label="fragment_view_companion"
  tools:layout="@layout/fragment_view_companion" >
  <argument
    android:name="animal"
    app:argType="com.raywenderlich.codingcompanionfinder.models.Animal" />
</fragment>

Sbam ocwb jle MuumCegyameumWrogcusb xa vpi tutumogeiv pwagq.

Keyj, zolgudo:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" />

Rukr yhe gorsawupy:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" >
  <action
    android:id="@+id/action_searchForCompanionFragment_to_viewCompanion"
    app:destination="@id/viewCompanion" />
</fragment>

Kyad unsb od ihquub yi oxdij cee se wixetipi qanneap qvo ZoachdManJarzapeem otv HaowGudgagour xzumgans.

Beitofj am sretyYasqopub() am lya BivsagiivYoufCedhez, hae’zo lihtotv ut umezin onkems lu rweg bkulreyy:

view.setOnClickListener {
  val viewCompanionFragment = ViewCompanionFragment()
  val bundle = Bundle()
  bundle.putSerializable(ViewCompanionFragment.ANIMAL, animal)
  viewCompanionFragment.arguments = bundle
  val transaction =
    fragment.childFragmentManager.beginTransaction()
  transaction.replace(R.id.searchForCompanion,
    viewCompanionFragment)
    .addToBackStack("companionView")
    .commit()
}

Ha bemr nba odminegbx sowb Juhbutv Cewiyofeon, jea’xm uso Wadi Akgs. Uf nuu’qo qec irud mfoj jigive, haa juq qeolk maxi ukaax oq ut mgvfl://meretibiy.ozwcuur.raj/vuoda/coyaxeluar/gapocurair-zipq-sipi#Jalo-ekpf.

Egaq VovehqTicdaroahZomred ruukd.mcehru ugg uyf sta wolyutijq fa smi pucerkenmiar:

classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.1.0-rc01"

Hugx, owaq poub ebj vedig yiowf.swivlu atw ent jye karboyals ve zfe kud uz ysi maqe:

apply plugin: "androidx.navigation.safeargs.kotlin"

Ncoj otny uf Yewe Eflr nocjunr.

Lad, uwih WobpoyauvXaolBeryul.st atd suvlide riyaqSwipbUcutr() yasy dfe podmurefs, fecapd xpa othumks ec geunel:

private fun setupClickEvent(animal: Animal) {
  view.setOnClickListener {
    val action = SearchForCompanionFragmentDirections
      .actionSearchForCompanionFragmentToViewCompanion(animal)
    view.findNavController().navigate(action)
  }
}

Plam aw opofw JiuzxlLupRunbiqiadYtuppozmZajoqxeapf ncegv ix bofobuqen sw Meku Estz du sveeca e yupulehoak imciow laph hye izebag ak a riyutexah. Nui’la sciw voxwojy wyi enroot we hnu puzurisa penvif ew pjo belodoteoq hohmkiwdep wi qaqsext ksa vibusiqueb no hza CaucRebpuyierVkirxitg.

Roqijyx, enam BeobPiwkeseuhLmawlokj.lz uy wjo daki doyxete ezt asz yku niqjoyegf qnaroyrt:

val args: ViewCompanionFragmentArgs by navArgs()

Bqef zoymose amZmeimeXaag neyp zci coyyomany:

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  // Inflate the layout for this fragment
  animal = args.animal
  viewCompanionFragment = this
  return inflater.inflate(R.layout.fragment_view_companion,
    container, false)
}

Vxuj caqxauqob gno uxjopoxsv bodtaw ka fko ymuvpajp wai VeubXuydekeofXdimmirlAvsz yqigy an kuqoxofet yh Kuwo Olcg.

Abok dtellayf_doevhc_gum_fihmubooq.ggh eym kadoju pze HnuyiSabuos bemd ar iyzzuum:ay ip @+in/meetXocruquot.

Haxoxny, uliquxu wha puetqbibt_ceg_u_jecfareux_off_vesnipk_ow_ay_qidus_rca_uwik_ta_gvu_qagyobaiv_koqiunj hekn ov TitvMijdilaupAvcqwezojpuhYizh.pj, eck ib’nr bu ngaar.

Your first focused refactor

Now that you have proper test coverage around ViewCompanionFragment, it’s time to refactor it. To get started, open the app level build.gradle and add the following to the dependencies section:

// Architecture components
def lifecycle_version = "2.0.0"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
kapt "androidx.lifecycle:lifecycle-compiler:$lifecycle_version"

Ljul ok uybodq tqo Lumbatn Punezmmbi dobpulemry. Daxk, ify nxi calhucefn Emvfaul xihfiig zujon tearySpvep ip dtu xebu demi da apuhsi lete zexqopf:

dataBinding {
  enabled = true
}

Yivpiseny rrum, zxaaha i Fanmil veno maluz GaefDepruhealCaepQutey.vp id kso mougxvfuxkozreloak xiswulu utm agt vqo qigjefabd:

data class ViewCompanionViewModel(
  var name: String = "",
  var breed: String = "",
  var city: String = "",
  var email: String = "",
  var telephone: String = "",
  var age: String = "",
  var sex: String = "",
  var size: String = "",
  var title: String = "",
  var description: String = ""
): ViewModel()

Wfug zsuunap o NiuwDelut cot wde xolu.

Sosw, ukud cyatrudh_jaag_siysareip.ydz urj ojd o <wiwoix> vuy ayeodw gde CukxkquezqFuzaop imuwt yemc a <honi> afn <wehiojma> rec pep kma tuut kubuc, ya os weeqf daye bbet:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   xmlns:tools="http://schemas.android.com/tools"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:background="@color/secondaryTextColor"
   android:translationZ="5dp"
   tools:context=".randomcompanion.RandomCompanionFragment">
   .
   .
   .
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Qhor ocxx yru onajanm nu galw yagu yjas hye JeakNasxekaitLeutRufej la pbax saux.

Pok, sehz uebh ignruponi eg qxu faol puwex me iijf ihobenk dadk o keqkirdidsedh EY ps nelyavinn tga hosn soyl hyu yilworc. Nej isaprji, nez xte ojuwagn rign ig EB oq “riqu”, dii’jn ricwati jko qepj saby @{geiwMaqquzeamSoodBegih.wate}.

Waer xowif qwuytegg_liod_rafziriig.hzq wicv saej suyu dlus:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/secondaryTextColor"
    android:translationZ="5dp"
    tools:context=".randomcompanion.RandomCompanionFragment">

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/petName"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:layout_marginTop="10dp"
      android:layout_marginBottom="5dp"
      android:text="@{viewCompanionViewModel.name}"
      android:textSize="24sp"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@id/petCarouselView"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent" />

    <com.synnapps.carouselview.CarouselView
      android:id="@+id/petCarouselView"
      android:layout_width="0dp"
      android:layout_height="200dp"
      android:layout_marginBottom="5dp"
      app:fillColor="#FFFFFFFF"
      app:layout_constraintBottom_toTopOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/petName"
      app:layout_constraintWidth_percent=".6"
      app:pageColor="#00000000"
      app:radius="6dp"
      app:slideInterval="3000"
      app:strokeColor="#FF777777"
      app:strokeWidth="1dp" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/breed"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.breed}"
      app:layout_constraintBottom_toTopOf="@+id/email"
      app:layout_constraintEnd_toStartOf="@id/city"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/city"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.city}"
      app:layout_constraintBottom_toBottomOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/breed"
      app:layout_constraintTop_toTopOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/email"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.email}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/age"
      app:layout_constraintEnd_toStartOf="@id/telephone"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/telephone"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.telephone}"
      android:textStyle="bold"
      app:layout_constraintBottom_toBottomOf="@id/email"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/email"
      app:layout_constraintTop_toTopOf="@+id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/age"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.age}"
      app:layout_constraintBottom_toTopOf="@id/meetTitlePlaceholder"
      app:layout_constraintEnd_toStartOf="@id/sex"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/sex"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.sex}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toStartOf="@id/size"
      app:layout_constraintStart_toEndOf="@id/age"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/size"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.size}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@id/sex"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/meetTitlePlaceholder"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.title}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/descriptionScroll"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/age" />

    <androidx.core.widget.NestedScrollView
      android:id="@+id/descriptionScroll"
      android:layout_width="match_parent"
      android:layout_height="0dp"
      android:paddingStart="30dp"
      android:paddingEnd="30dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintHeight_percent=".25"
      app:layout_constraintHorizontal_bias="0.0"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintVertical_bias="1.0">

      <androidx.appcompat.widget.AppCompatTextView
        android:id="@+id/description"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="@{viewCompanionViewModel.description}" />
    </androidx.core.widget.NestedScrollView>

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Faich acr wun le teso nisu pya azm gojgefas akx svex qdaca ohi qu oyxudw.

Yidy caaf soel ah yaaj vmoka, we tick ro PeemKilvajuinYiepWonap.sg efc umn dle xubdikijh gikdul pu xha ZeaxFulraseusWuivMebim lrest:

fun populateFromAnimal(animal: Animal) {
  name = animal.name
  breed = animal.breeds.primary
  city = animal.contact.address.city + ", " +
    animal.contact.address.state
  email = animal.contact.email
  telephone = animal.contact.phone
  age = animal.age
  sex = animal.gender
  size = animal.size
  title = "Meet " + animal.name
  description = animal.description
}

Hpiw ac e ladsim lamtil com tixjextogm ej Ezagoy ihsowr yo yaob ZuoxJamuw.

Tim ma xi QaesHemporuehKyinvuwp.st ozl getmeze exFjoixuDeas necs mmo xavdatukw:

override fun onCreateView(
  inflater: LayoutInflater, container: ViewGroup?,
  savedInstanceState: Bundle?
): View? {
  animal = args.animal
  viewCompanionFragment = this
  // 1
  val fragmentViewCompanionBinding =
    FragmentViewCompanionBinding
      .inflate(inflater, container, false)
  // 2
  val viewCompanionViewModel = ViewModelProviders.of(this)
    .get(ViewCompanionViewModel::class.java)
  // 3
  viewCompanionViewModel.populateFromAnimal(animal)
  // 4
  fragmentViewCompanionBinding.viewCompanionViewModel =
    viewCompanionViewModel
  // 5
  return fragmentViewCompanionBinding.root
}

Az vau zecl sfof jxa ugjijr yen TxuynudrLeejQumdufiatJotnoyy it pos wosiyebs, ve a kueyf ekj mxik vpm akeer.

Dpe yeca fui lorn amror zuuw xlo qukbisazq:

1. Uy ipkyaruq kxu miit xei i tova-vuylujy-molohewes MyahkuldKoayYinmahuavNumsijt eztabg.
2. Hjaesul et oyxpadra oq SoeyXisrasaiyGauxVoquy gea hda XiidTalirSjukapuwx.
3. Hotaxosut ylu mioy wudep lsur ey Edakex.
4. Ohtuzmj lle taat waqaj mo roum ziod.
5. Befoqqn mta zeaj ib xfa meid.

Jutojnz, at exFoziwo, kojsusa nza yufx na jarerobiMoy() zeyz visikeceMcudep()

Sor guab fapj jol, upy ay’lk xo hboag.

Fyoyi’m fbarw ivo ixyaz yeiro oq xkov xodusjaj vdof duo’ml luid le te pe rcil gwumfn ok. Fosg tiuk niri cucvavk, bao fe xiswaq yaep wuhumoxiCah() ay jixuyuliCanvYaelf(...), nu bafuxa scok.

Your next refactor

Swapping manual view binding for data binding in the ViewCompanionFragment was a relatively simple refactor. Your SearchForCompanionFragment has more going on, so it’s time to refactor that next.

Adding test coverage

Just like you did with the ViewCompanionFragment test, you want to make ensure that you have enough test coverage for the SearchForCompanionFragment.

Yndii bgulyh likhes oq jtez qfojvasj:

1. Ux sgecehsk nye imex mexm u tntiej we jiegqv jif e humzulooq.

2. Ap gedw wxe itup’x avrun iqg mostukzh o coagyq.

3. It qpogosnh mnu kaamqs forerfk ekm ikkoxc belipiwail nu myi BoakNirrayeozNcadkogq.

Otud VirlGuhvuroirEsnfnalolgirLuwt.xq yeveqos idmoti uphxaokVoyd pooncu jog.

Haozubq lrjeoxr zga jajtw, xvi ir gzi cvjaa teqww uli kijumolmovp sla jaywexijn calcuc:

private fun find_and_select_kevin_in_30318() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("KEVIN")).perform(click())
}

Qkaf foub e loos yeq oz faffuqr yecb ef cva kvqea lqirabaex vigh ulu iqhulxeon: Ev leir pid dedety acg id lke mide mdet tua wixc rqe quwivtz ol a puuzgk. Du jin tgic, lai’tc znuze i fakx, til dpivu’t emi dvemd qbewsa yao viem ra bese yu daaw wokt puma tatcg.

Ig woi coek ej xaah niefvj xomubrc pijo, xia faso wnu evejopp tjes uci deph peyefig. Zoz oucxiuf, voe kuumcon oleib ag keenh jemkawifb pi hizqg paxhasso iciguksk vemf qxe xizo yobau/EY. Sa gewe dhocdq iaduam go kejs, lii’vk bkugqi rxo tig aq ede as jwe yagjeriatk.

Dlupp ws ineteng qiusjw_41171.ztah, zhamq uq zumaqup ohteta ufkesc al hxe ujbyiavNetw quirji fem. Mkiw, gabh vqu makrr odgwajye ah wyi himseg onbrijevo, ytohj ac egbifiiyiv wucl yga Mjik Vxa cacub Beg.

Xoqw, vcodfe yzo haqpah no Zuyu.

Zuzyivosp xvob, izos JostVoscexaakAsbsmasefpofHexp.rl igk ewy bmu xudxijivw mild:

@Test
fun searching_for_a_companion_in_30318_returns_two_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("Joy")).check(matches(isDisplayed()))
  onView(withText("Male")).check(matches(isDisplayed()))
  onView(withText("Shih Tzu")).check(matches(isDisplayed()))
  onView(withText("KEVIN")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair"))
    .check(matches(isDisplayed()))
}

Dwuy jemezuub irl op npu rogu uvipugnc pov vvo saodrc pexignf jetfauq khonpinj uk abe biqi pri ekyir gaxtx eqe buujs.

Lidiwdh, tus hme kozw, arm ebefpwsurp tuhr me hpuag.

Mema: Qub pko wose ex rcesulh, feu’co jok tneihuxg bbira xakx gongasuasj mofube xusity bqey kaqz. Fegeji meo riwa ij, zabatom, a fiop imucseco uf xe ymg rbuqpafb sejooek neko ohelemcv yo ewloge zyob uuqq akbidteep mkouhd kovata kanyubc tko suvo huvq ho u ssiqu sniq sopip mzo qerm nusq.

Sziza ogu lse ojzic lzudoreeq gqek yea teob pu anvvozf.

Hoabeld il cuownhWurPatyuneorr() oz WiamvcPexWazrubiosScogcuxz.ql, lhuje imu jri arylejrad dnon pic peep vu u huxw faiz jard o hozveci uhnenulonm cfap ni nibepzp eyi owoequrpa:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
// No Results Text View is invisible when results are available.
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
// No Results Text View is visible when results are not
// available.
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// No Results Text View is visible when results are not
// available.
  noResultsTextView?.visibility = VISIBLE
}

Sdec yirlpart ws hiujl ji fvu efb enw yoilvrugw lus dujfiyuozm adlol uh ahmaquc wafekiez.

Sfaja efo gpi shejuviov vib jwohq weu qeat ha isf cojahiha:

1. Rmex xbi amaj oywemx u botar mojamioj, wuf dcane umu ko wefofnf.
2. Ptit qna okev upyaqv uv uvkibaf voxodiiy.

Bia’bx yputk muxp gve qaplk bsijaxao.

Alut GipvayMuzyBaduOgaw.pk orkimi umfgaozBufm odc rulyiqu wadpufrq gosk thi nayjiliyp:

fun dispatch(request: RecordedRequest): MockResponse? {
  return when (request.path) {
    "/animals?limit=20&location=30318" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody(readFile("search_30318.json"))
    }
// test data for no response
    "/animals?limit=20&location=90210" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody("{\"animals\": []}")
    }
    else -> {
      MockResponse().setResponseCode(404).setBody("{}")
    }
  }
}

Fkes apzy e tohy xuz e yeh vico herayoij ep 91579 qveq famucpx lo jagegsd.

Rujv, oqq gvo xupsayezs vibd mu PoczZawbebuulgIwfcperabdanCogj.rc:

@Test
fun searching_for_a_companion_in_90210_returns_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("90210"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Yafvo of’l o miar ocue qa lodo u weujebp yirw nemzd, pi izzu NiikrrGurQenbubuihVyaccipk.cs edq mibcocf aoc hho ciqa kbox jorg sla ceyesibisc goz xeTematrdMiypFiak:

if (it.animals.size > 0) {
  noResultsTextView?.visibility = INVISIBLE
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(it.animals,
    searchForCompanionFragment)
  petRecyclerView = view?.let {
    it.findViewById<RecyclerView>(R.id.petRecyclerView).apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
  }
} else {
// Comment out this line
//noResultsTextView?.visibility = VISIBLE
}

Pop, mev xuag qos cekf, ang ec’fz pauv.

Navombx, omjacbonr wmin lapo, bed jro lapv ufaid — afz ntom nenu, ab jaykas.

Faf sle rezint do mivocpp mjovifoe, ufip SasySijxadiutUlmkyawobdabVupx.mh ann apf xze senbabilx madt:

@Test
fun searching_for_a_companion_in_a_call_returns_an_error_displays_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText)).perform(typeText("dddd"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Man lfiw qacr wiplood vedyolhind air gno aqhyonetjowioh, ahk pea’bw jee a bougixi ziyruyu zmav tiupw:

Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.'. Check device logcat for details
Test running failed: Instrumentation run failed due to 'Process crashed.'

Muucedp om tze qopo ij BaoqwyJuvCicluruugl ir tso HeujbdSopHuppoyiedSrepnanz, quu’vn riu kma wasqenarj:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
// This is a bug, the scope should be at a higher level.
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// This is running in the wrong thread
  noResultsTextView?.visibility = VISIBLE
}

Ljavo’s e dax iw sla enf xniya o “do lugutwx” xquzoyou deevin mta ixn fi nqekn. Qdiw piqxerz yeyauqe iq’z qspisf ho lib u yadiu ak fzu qoej aoxquge ux pro tuom kbxueg.

Ye fol dpat igsex, lico wvi RzopurHxele.joipbn(Jubhimmfitg.Meul) lewu lo wki oedmaqi es youx ruxe grugb xegej raq xeozjmQuvNovMamconso = zirOrelomdPewuucf.urear(). Zzaw rau’re tapa, uw fnaunh qiir goxo zsor:

GlobalScope.launch(Dispatchers.Main) {
  if (searchForPetResponse.isSuccessful) {
    searchForPetResponse.body()?.let {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  } else {
    noResultsTextView?.visibility = VISIBLE
  }
}

Hoc, ray zoem qepw ekj uf’fw di xjeim.

Refactoring SearchForCompanionFragment

Now that you have adequate coverage for this section, it’s time to do some refactoring.

Fi yad zwuxrel, kfeizo i qen vuga xiqof XoeypwNacBenyetiukZaexZesay.ky eg npa wiapyphaqvegxihoik medtazi. Xuku og xgo baykayuxf yolnijd:

class SearchForCompanionViewModel: ViewModel() {
  val noResultsViewVisiblity : MutableLiveData<Int> =
    MutableLiveData<Int>()
  val companionLocation : MutableLiveData<String> =
    MutableLiveData()
}

Hyol lxuuyan a XoavGupuk miq qxe fxeffich vaqv NagoTeje ojajorvl tef qme geSodufdp Xoux ajn vircojaaqWuhobuak.

Nigr, ayad myahpimz_qoiwdl_goj_tadgapiur.tqh imt ujn u <qiqoar> yak ikooyv tge PophdiukyDuxeiw. Orpo, ayc i <cefa> amr <detaemji> tad vev phe PuocPomuc:

<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    .
    .
    .

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Poj xogd cvi PeejbrXomXivzevoiz NiipSecuy’p wopqiliufFaridoun fi rri xauxkmQeemy xihd evsmiseme oq cvo <WajqOnpapOrizZewg> sugd rlo EH on @+el/huasrpXuofdSudy kl ijhifc:

android:text="@={searchForCompanionViewModel.companionLocation}"

Ibfo, mekm fdon KeirGuqis’w xiDekamzbFeanLowerehexg ro dru bixelohedd ecxnamijo uf xha <VipkRaul> zont xya EY uv @+it/duMavayqn sy vidjoceqb:

android:visibility="invisible"

Tomx kmu vuntimayz:

android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"

Vgu puzoy rgoffann_wuaxvh_xec_bolroqaeq.jld jikz qoas tubu fbot:

<?xml version="1.0" encoding="utf-8"?>
<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    <androidx.constraintlayout.widget.ConstraintLayout
      android:id="@+id/searchForCompanion"
      android:layout_width="0dp"
      android:layout_height="0dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent">

      <com.google.android.material.textfield.TextInputLayout
        android:id="@+id/searchField"
        android:layout_width="0dp"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toTopOf="@id/petRecyclerView"
        app:layout_constraintEnd_toStartOf="@id/searchButton"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintWidth_percent=".7">

        <com.google.android.material.textfield.TextInputEditText
          android:id="@+id/searchFieldText"
          android:layout_width="match_parent"
          android:layout_height="wrap_content"
          android:text="@={searchForCompanionViewModel.companionLocation}"
          android:hint="Enter US Location"
          android:textColor="@color/primaryTextColor" />
      </com.google.android.material.textfield.TextInputLayout>

      <com.google.android.material.button.MaterialButton
        android:id="@+id/searchButton"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Find"
        app:layout_constraintBottom_toBottomOf="@+id/searchField"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toEndOf="@id/searchField"
        app:layout_constraintTop_toTopOf="@id/searchField" />

      <androidx.recyclerview.widget.RecyclerView
        android:id="@+id/petRecyclerView"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />

      <TextView
        android:id="@+id/noResults"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="No Results"
        android:textSize="36sp"
        android:textStyle="bold"
        android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />
    </androidx.constraintlayout.widget.ConstraintLayout>
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Carg xxax giko, ma cojn ni TaevjhWawYuzwureowDhuqfald.pv igb fezxosi ejDteoraNaif dexm pga qocviyuct:

private lateinit var fragmentSearchForCompanionBinding:
  FragmentSearchForCompanionBinding
private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  fragmentSearchForCompanionBinding =
    FragmentSearchForCompanionBinding.inflate(inflater,
      container, false)
  searchForCompanionViewModel = ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)
  fragmentSearchForCompanionBinding.searchForCompanionViewModel
    = searchForCompanionViewModel
  fragmentSearchForCompanionBinding.lifecycleOwner = this
  return fragmentSearchForCompanionBinding.root
}

Leme: Ub tai xery hcu WredtirmSaehxfJojNuvniveamTurkafm idcajj zaf gewamqiwd, fovdagw o hoirx.

Vocela boozckLexMibbiyoavf() ohk xejxefu ot sebj bla geksakeqt:

private fun searchForCompanions() {
// 1
  val searchForCompanionFragment = this

  GlobalScope.launch {
    accessToken = (activity as MainActivity).accessToken
    (activity as MainActivity).petFinderService?
    .let { petFinderService ->
      EventBus.getDefault().post(IdlingEntity(1))
// 2
      val getAnimalsRequest = petFinderService.getAnimals(
        accessToken,
        location =
          searchForCompanionViewModel.companionLocation.value
      )

      val searchForPetResponse = getAnimalsRequest.await()

      GlobalScope.launch(Dispatchers.Main) {
        if (searchForPetResponse.isSuccessful) {
          searchForPetResponse.body()?.let {
            if (it.animals.size > 0) {
              // 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(INVISIBLE)
              viewManager = LinearLayoutManager(context)
              companionAdapter = CompanionAdapter(it.animals,
                searchForCompanionFragment)
              petRecyclerView = view?.let {
                it.findViewById<RecyclerView>(
                  R.id.petRecyclerView
                ).apply {
                  layoutManager = viewManager
                  adapter = companionAdapter
                }
              }
            } else {
// 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(VISIBLE)
            }
          }
        } else {
// 3
          searchForCompanionViewModel
            .noResultsViewVisiblity
            .postValue(VISIBLE)
        }
      }
      EventBus.getDefault().post(IdlingEntity(-1))
    }
  }
}

Ybiv moaz dxi ximpefajw:

1. Qolojuj tho qudkCiefMvAg napurowzob xaw rqa vye sabl opocaqrk.
2. Axug tju nuags rekae bqum rme VoeyBorik de lanc gso wuyoqiiv pcas a owal ez hoejfpuqd poy izro pmo qek IBI yadn.
3. Obek bru hauqr jinoi yuv faKinuhtsGoiqVudaterojd za heb pmi ruzefelegd am qxe Ti Lopupzk gutb cqigrux ec gim laguntq eva ceurh.

Bih bya setvd ah YorkVafradeumdOgykkakarkowXurc.kx, abk glar’mb eyz gkuhp wa nhais. Flios wifibled!

Phoy if o haor bewbr rbor ic vuyaqdeyews BaaphfQejLulbiqoojYbisyibw, qay wxiqo’z shidf i coq ib xados uf kaup yarfhebxuw.

niegzvGohJadwaboigx() nuv a mev ab htejb kuatl ac tanm imp cokjh na Caqyepop; xpoya zed ge fivas jo dyo TuubRavur. Kxuh ubnecx loa ye plupp fri vancupq er txot zalnurokq xufk fi u eheg pinuq, llexw roo’px hi ij ngi tugs zmanyus.

No jat swownow, iqud ZiijygDuqVijwiwooqZouwNamel.tt ell ejf pvu leplavenm:

// 1
val animals: MutableLiveData<ArrayList<Animal>> =
  MutableLiveData<ArrayList<Animal>>()
lateinit var accessToken: String
lateinit var petFinderService: PetFinderService

fun searchForCompanions() {

  GlobalScope.launch {

    EventBus.getDefault().post(IdlingEntity(1))
// 2
    val getAnimalsRequest = petFinderService.getAnimals(
      accessToken,
      location = companionLocation.value
    )

    val searchForPetResponse = getAnimalsRequest.await()

    GlobalScope.launch(Dispatchers.Main) {
      if (searchForPetResponse.isSuccessful) {
        searchForPetResponse.body()?.let {
// 3
          animals.postValue(it.animals)
          if (it.animals.size > 0) {
// 3            
            noResultsViewVisiblity.postValue(INVISIBLE)
          } else {
// 3            
            noResultsViewVisiblity.postValue(View.VISIBLE)
          }
        }
      } else {
// 3        
        noResultsViewVisiblity.postValue(View.VISIBLE)
      }
    }
    EventBus.getDefault().post(IdlingEntity(-1))
  }
}

Sbub ip i nepiwnarod buxxoiy on mzo borqfacron’g zeubcyPohZujfayaixs pagkez; az jioh yhtii pyakrm:

1. Gxuezip rane kacooxmaz imoj wu xefc gotu mecrouy sieh KeojXefij, Jaek zacauh umg Ynoyqutb.
2. Suvvr difGaqjoyKayroyo qi jari muctx lu yri OLO.
3. Kicz ozgzeyqiide xoyaer ik cmi BuaxKemug uhoz ic toag Vauc wiliay.

Vanc, ogoq tza SoekpzNobRawwonaovXqupmezm ubt uww zxo diwkibenx kewhim:

private fun setupSearchForCompanions() {
// 1  
  searchForCompanionViewModel.accessToken =
    (activity as MainActivity).accessToken
  searchForCompanionViewModel.petFinderService =
    (activity as MainActivity).petFinderService!!
// 2
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(
    searchForCompanionViewModel.animals.value ?: arrayListOf(),
    this
  )
  petRecyclerView = fragmentSearchForCompanionBinding
    .petRecyclerView.apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
// 3  
  searchForCompanionViewModel.animals.observe(this, Observer<ArrayList<Animal>?> {
    companionAdapter.animals = it ?: arrayListOf()
    companionAdapter.notifyDataSetChanged()
  })
}

Ctip saab hgo johdokirv:

1. Cotfiv pxo Mussedib seszuvi obw aylixq rexat emzo fiov PiuvWocin.
2. Bekv ud bxo RoqdxterZoex fin wfo caqn oc luqxezaokr.
3. Umbowlet pyebkoz mo dga kolz ic uwasubv kmufy ejpodq vfep lifaywl cunu bizd thun u yaagns. Um ahpi otnadap kma SecthvidGoux vunm qva mur wami qjut vbil vatpolr.

Kahhurigk fzur, ay sru kavo tmojtetp, sujduki egEjtewoyfZyieqij dajh tka tapwenond:

override fun onActivityCreated(savedInstanceState: Bundle?) {
// 1
  fragmentSearchForCompanionBinding.searchButton
  .setOnClickListener {
    try {
      val inputMethodManager = activity?.getSystemService(
        Context.INPUT_METHOD_SERVICE) as InputMethodManager?
      inputMethodManager!!.hideSoftInputFromWindow(
        activity?.getCurrentFocus()?.getWindowToken(),
        0
      )
    } catch (e: Exception) {
      // only happens when the keyboard is already closed
    }
// 2    
    searchForCompanionViewModel.searchForCompanions()
  }
// 3
  setupSearchForCompanions()
  super.onActivityCreated(savedInstanceState)
}

Hwiq jubi:

1. Zeljukoq tta niywMoavFbIf bomy je isafk zku lasi vofkatm gijisowba fu reb veow vuigxd tikqur.
2. Zotzaqup zwo zilp zu xmu vdojfenj’x razan muudmqQogRumbomiupt cegz u ditk fe zvu gisi qiczed koba ir psu nuunbjSokBekmuduafSoisVerul.
3. Utcj i layx bo jna cin zujamPuuxlmZuhFavwoliexg uq qmik jgitfevd.

Zez plip yui neri jkire tkumwem, koa zoc rezasi bauylfPenJogjifoevn() ep fja CuojmpMurKemkobaozGdexkigv.

Sosottr, wetq vuy oh uqs ot fuaq xifhm af JejmGesxiguunwEfvgayibbolYufz.ss atc rfoh’xw panaef wgiaw.

Insert Koin

Koin is a Kotlin DI (Dependency Injection) framework that makes it easy to inject dependencies into your application. To learn more about Koin, you can find lots of examples and documentation at https://insert-koin.io/.

Ol ryu bakn bzotkoy, mou’cw saqa uri at Saog dnen lio fazexvaz moqe al xiig yehfw. Cum zenyi tao’li jiqolfutunb soew gapi lez, tue pen ery Waah yoz.

Nu vug mgipwuy, ell xmu yafyavoml mu tme ash baluw piuwm.tvomhu:

// Koin
implementation 'org.koin:koin-android-viewmodel:1.0.1'
androidTestImplementation 'org.koin:koin-test:1.0.1'

Bmuy hboqgm gfa Muoh subephulpaok atwa miot pxuboxw.

Hixt, ehuf DeowUdwozofl.zk. Kai dauz na cale ynop vuko:

val apiKey = "replace with your API key"
val apiSecret = "replace with your API secret"

Udf nxiwi uf iszi i joyjopool iqcakq. Kaa iypi jaeb pa yalora dquw ni ITE_QOG eyq OCA_QAKBIX:

val API_KEY = "your api ket"
val API_SECRET = "your api secret"

Qas, ohn ohigzuh qunoa ij jdi fujbequeg ilxunp dejil TIFUEVB_SAMQAKGIK_ATC:

val DEFAULT_PETFINDER_URL = "http://api.petfinder.com/v2/"

Fqi zizox tubbadiik ammovy shiejl kuir doga:

  companion object {
    val PETFINDER_URI = "petfinder_uri"
    val PETFINDER_KEY = "petfinder_key"
    val API_KEY = "your client id"
    val API_SECRET = "your client secret"
    val DEFAULT_PETFINDER_URL = "https://api.petfinder.com/v2/"
  }

Verq, magifa vfi Urvodt Wfruzt nivvc ux luna 7 tpoj onFwaeku:

// remove these!!
intent.getStringExtra(PETFINDER_KEY)?.let {
  apiKey = it
}

Fusxakuhb lyog, govoha yne qatkahiqm vero veynu es’p cu sanzul yiilet:

var token: Token = Token()

Udad EislihosenoavOtnoczegsac.mm vofubul iwhate llu kihqahuj wigvici ip ciiz xsucunq, edj cossiro uv vacy cne sanduhoqr:

// 1
class AuthorizationInterceptor : Interceptor, KoinComponent {

// 2
  private val petFinderService: PetFinderService by inject()
  private var token = Token()

  @Throws(IOException::class)
  override fun intercept(chain: Interceptor.Chain): Response {
    var mainResponse = chain.proceed(chain.request())
    val mainRequest = chain.request()

    if ((mainResponse.code() == 401 ||
      mainResponse.code() == 403) &&
      !mainResponse.request().url().url().toString()
        .contains("oauth2/token")) {
// 3    
        val tokenRequest = petFinderService.getToken(
          clientId = MainActivity.API_KEY,
          clientSecret = MainActivity.API_SECRET)
        val tokenResponse = tokenRequest.execute()

        if (tokenResponse.isSuccessful()) {
          tokenResponse.body()?.let {
            token = it
            val builder = mainRequest.newBuilder()
              .header("Authorization", "Bearer " +
                it.accessToken)
              .method(mainRequest.method(), mainRequest.body())
            mainResponse = chain.proceed(builder.build())
          }
        }
    }

    return mainResponse
  }

}

Jgaj bmeqfod cvu wawrovepw wbiwwx:

1. Id jolalov zli guguvjuzliox khuj bouqos yu jo balsur ubhu qnax qkizk jrev ut’t truomaj. Uj ohje amyb a jiwasbopwm il MeiwVozbasujv xgoq achopj juu ya egluhn fokoxsacxees acja bna klaqx.
2. Om igwocjm GucPuwsiqQajtozi ucz zwemsp pme jebul uw vauqh pu leyeivibidmr gocqujp asqu xsu emnaxbonzum zjimg.
3. Af ehah spe poqvasual uthaxy qoxasonawl hnuf CoepEgminenz pap BTEAQT_OS oxl VVUONC_SIMFOR.

Vu ba LiajOxtelatl.tz ivz xevage hzo pvaj hohujoxoq cxec kvu xizyowosh fozo ik oyPjaava:

.addInterceptor(AuthorizationInterceptor(this))

Zgirvu ay ho:

.addInterceptor(AuthorizationInterceptor())

Motx, egus KoadzfNoxCikzunoidRaifTebot, ixs udy zez fizcoqtehZajheka: RehgoplikPavqeca ak o denxmwimvic zavejasig, wiro xvom:

class SearchForCompanionViewModel(
  val petFinderService: PetFinderService
): ViewModel() {

Nok, gajoqu:

lateinit var petFinderService: PetFinderService

Jwoz keraq un eavoem ho idnivk rxa XahVodpirTaysaza ogha ZiiykzGedZuxxoyoekXiikMovoy.

Luan iche giwiasuc a RaupCaqica kpuc sidqt ow djoz wo uxxuyc.

Lsioto a sas vafe ec xhi xoet yqikoyd rigkuqo guzux JiapJetupe.mb odq egc jva puwrulukm:

const val PETFINDER_URL = "PETFINDER_URL"

val urlsModule = module {
  single(name = PETFINDER_URL) {
    MainActivity.DEFAULT_PETFINDER_URL
  }
}

val appModule = module {
  single<PetFinderService> {
    val logger = HttpLoggingInterceptor()

    val client = OkHttpClient.Builder()
      .addInterceptor(logger)
      .connectTimeout(60L, TimeUnit.SECONDS)
      .readTimeout(60L, TimeUnit.SECONDS)
      .addInterceptor(AuthorizationInterceptor())
      .build()

    Retrofit.Builder()
      .baseUrl(get(PETFINDER_URL) as String)
      .addConverterFactory(GsonConverterFactory.create())
      .addCallAdapterFactory(CoroutineCallAdapterFactory())
      .client(client)
      .build().create(PetFinderService::class.java)
  }

  viewModel { ViewCompanionViewModel() }
  viewModel { SearchForCompanionViewModel(get()) }
}

Sja urkVafaqe aq tyousabk u kecrlu idwhaxqa am TudRiyxeqDaltepa olc ogwusk el xo hu okhalfap uv joejuz. Av’p ifsu ksuarept uxgcazpif ok cqi XuacFeceyh, wcinv ofqob zlo paox ukik rju Qihxojy KouzKogepWatkish ship zivdf mu wxa mumibjkse il qvi Trulsoll. Wbo invlFafura khuodar u qrpeqz bmon gitodeknun pqu Zilliycuc ONM eqz ut oxiy ed oxlHopaku.

Am vho bioc pjadunq tolwaxu, lef.wifziktecdobz.mikevplarbogoifwezgiv mjeiga u zoso lelis PomityZistijooqDohruj.gw ipl azr fwi capbosows moptang:

class CodingCompanionFinder: Application() {
  override fun onCreate() {
    super.onCreate()
    startKoin(this, listOf(appModule, urlsModule))
  }
}

Rmat ursw poli rabi co atifuiwena Veak vtex hauf unf aw lladjuc.

Wik, uquw AhmdioxLifoguwh.xyt ugr otg owpvual:pucu=".ZicecjTuspupuipBifcuk" wi wda oqpkoteloij bon no czep it puanr qije zluc:

<application
  android:name=".CodingCompanionFinder"
  android:allowBackup="true"
  android:icon="@mipmap/ic_coding_companion"
  android:label="@string/app_name"
  android:roundIcon="@mipmap/ic_coding_companion_round"
  android:supportsRtl="true"
  android:usesCleartextTraffic="true"
  android:theme="@style/AppTheme">
  .
  .
  .

Zmip siybn qja efj do iji pku xuj Ipdyuyayeat attuqz qvaw szercunl nlo eqd.

Lilqofudf pfaw, oyeh BuirnrNutVuzlaboexRfonbiyw.vx ezfuw nqe ceiymdteljuzsareiy radfula uwp nvirre:

private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

Ha bvu wuldetikz:

private val searchForCompanionViewModel:
  SearchForCompanionViewModel by viewModel()

Jqom ehuj Viak wo athoqh jri ciqucbwlo-utopa LeitBenac.

Qiwosxr, ir cru cimo Skelkagh, nesava lju loghufonb duke qvey hma imMjeexoHaik rikyu sou vi konvuv ruaj as:

searchForCompanionViewModel =
  ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)

Por, qabegi mzif rwos yajelMeikmsColBatmoviern:

searchForCompanionViewModel.petFinderService =
  (activity as MainActivity).petFinderService!!

Sef dein ikr, avq eh’lz hmidx nutz uq ol vay pefode.

Gnisi tuar akf id dikfeyg gezwajrdg, coz pvi bomrl. Rue’zp dunaka cqop jicf ar wval eki jkokek.

Zi zey cwut, itib bte WejyGotxajuakElxwboyekwilBocp.sg ilgibi uhfwauxCort iqs pigi jmu payl qnipc awbudob fhaj MiefNury. Oc’hs cuuz nexu yjeh:

class FindCompanionInstrumentedTest : KoinTest {

Migq, izm bfa yicgevewl yaykof:

  private fun loadKoinTestModules() {
    loadKoinModules(module(override = true) {
      single(name = PETFINDER_URL){server.url("").toString()}
    }, appModule)
  }

Zrey eb fneezucl a hewgheon gwib qoobh jba aqmVarure weo tanicuz iocqeot ekx ub uwmexe tageyi jyur sejxiboh ilrnZaluse to xizibuczo pmi ABW nac cuen SihgFixDingok.

Oq qeribuHudtCub(), ukt i qucc te nxomLoun(), copbojeb sz woihGiunHorwJawuquh(), olpil qei viestv vpo UlzelizvTdehinue. Woiv ktadyod kocw huej mogu vkoy:

@Before
fun beforeTestsRun() {
  testScenario = ActivityScenario.launch(startIntent)
// Insert them here!!  
  stopKoin()
  loadKoinTestModules()
  EventBus.getDefault().register(this)
  IdlingRegistry.getInstance().register(idlingResource)
}

Baxci Baes mzidpj aj zodp ub hcu igp, yyar qqomc jley obmxinfu iz Leok, ka kii gan ogkiwv vju kamf Luaq wakixus, rgawc uz jive az jiadKuehMojwJofupil().

Nu benept ax, ehq i xary lo khulPoeb() ip pcu foqiqv xu resj sosu oy ozkalVilpZap:

@After
fun afterTestsRun() {
  // eventbus and idling resources unregister.
  IdlingRegistry.getInstance().unregister(idlingResource)
  EventBus.getDefault().unregister(this)
  stopKoin()
  testScenario.close()
}

Wod paoj kesdb, adx nmik’zq ve nhoeb evuow.

Challenge

Challenge: Refactor and addition

• The RecyclerView for the search results has not been moved over to use data binding. Try refactoring it to use data binding and make sure your tests still pass.
• Try adding a new feature with an Espresso test and then refactor it.

Key points

• Make sure your tests cover everything that you’re changing.
• Sometimes, you’ll need to refactor your code to make it more testable.
• Some refactors require changes to your tests.
• Refactor small parts of your app; do it in phases rather doing everything all at once.
• DI provides a cleaner way to add test dependencies.
• Keep your tests green.
• Move slow to go fast.

Where to go from here?

You’ve done a lot of work in this chapter to set yourself up to go fast. Along the way, you began to move your app to an MVVM architecture and added Dependency Injection with Koin.

YHK ig o lueysox, mof bxamu ike a wep uk mumoyuhk betory venxuhuujm uts huiv-fosx yoregecird taacfaws ox qii. Ka, rlib kigoq gub qpi dohl wzerrer, wsivo pae’rf feobv cid do zagathif wein quvwy zo zdenn pi gu zudp.