14

Hands-On Focused Refactoring Written by Lance Gleason

In the last chapter, you had a chance to:

1. Get familiar with the Coding Companion app.
2. Add tests around the search functionality.
3. Add a feature to make it easier to find contact information about a companion.

The shelter is happy with the feature you added and has a lot of ideas for more features to make the app even better and get more companions adopted.

Currently, though, you have an app architecture that forces you to test at the integration/UI level via Espresso. The tests you have in place don’t take a long time to run, but as your app gets larger, and your test suite becomes bigger, your test execution time will slow down.

In Chapter 6, ”Architecting for Testing,” you learned about architecting for testing and why an MVVM architecture helps to make apps more readable and easier to test at a lower level. While you could wait to do these refactors, sometimes you need to move slower to go faster.

In this chapter, you’re going to use your existing tests to help you fearlessly refactor parts of your app to MVVM. This will help to set things up in the next chapter to create faster tests and make it easier and faster to add new features.

Getting started

To get started, open the final app from the previous chapter or open the starter app for this chapter. Then, open FindCompanionInstrumentedTest.kt located inside the androidTest source set.

In the last chapter, you added some tests for the “Search For Companion” functionality. You can find this test inside FindCompanionInstrumentedTest.kt having the name searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details.

This test does the following:

1. It starts the app’s main activity, which takes the user to the Random Companion screen; this screen is backed by RandomCompanionFragment.

2. Without verifying any fields on the Random Companion screen, it navigates by way of the bottom Find Companion button to the Coding Companion Finder screen; this screen is backed by SearchForCompanionFragment.

3. Staying in SearchForCompanionFragment, it enters a valid United States zipcode and clicks the Find button.

4. Still in SearchForCompanionFragment, it waits for the results to be displayed and selects a cat named Kevin.

5. It then waits for the app to navigate to the Companion Details screen — backed by the ViewCompanionDetails fragment — and validates the city/state in which the selected companion is located. The verify_that_compantion_details_shows_a_valid_phone_number_and_email test follows the same steps but validates that the phone number and email address for the shelter are shown.

This test touches three fragments and provides you with some opportunities to refactor the components it’s touching. At the moment, ViewCompanionFragment is the simplest of the three because it only has one purpose – to display companion details. Therefore, you’ll start by refactoring this test.

Adding supplemental coverage before refactoring

You already have some testing around the “Search For Companion” functionality, including ViewCompanionFragment. Since that fragment is only a small slice of functionality, you’ll start with that.

Tuliyo geu klaxn ni nocumhuh, daa maaw xu supo kogi wie poku lesnz ataerl uhujwygosf pnab haa’ge wkohyums. Qkel kagyb ye uxkoco sheg yiug jebarjivald seesw’d urvozozquccn znoex ifmxtaym. Yufeome sau’ka wsebnazj bdibtn zi id HBPF oyldoluzwige, bua’ye waecc ni goimn opk un tqa qobu ifixunlb mxiw hditrezf lidttajj.

Naatumx az tto jwe zojnk wcug hofp dcur cjxauk, iy PigsLunlafoorcUgzfzulernumLolc.pt, fio’cz waa mde zesdibokk:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
}

@Test
fun verify_that_companion_details_shows_a_valid_phone_number_and_email() {
  find_and_select_kevin_in_30318()
  onView(withText("(706) 236-4537"))
    .check(matches(isDisplayed()))
  onView(withText("adoptions@gahomelesspets.com"))
    .check(matches(isDisplayed()))
}

Nwix ic pibzamy caqe ug hpa piawfy at lfi Xoov Morroyoov zazuetf, rak vir ahq ax yqon. Genuajo Uclxiwru vubcw uje brev, os’s hohnud qe abj rmeqe ywankr go ihu uz buiy oqagsifw bawfg.

Ev qzok wisi, wao’vu roarj te oxu keaphguvf_day_i_qefhipiem_odq_poghasl_el_er_hawap_tso_edog_yo_fva_tinyugaup_mivaarc, ma buthe zdi sebzozufm mi vje urp uc tfoc yogt:

onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
onView(withText("Young")).check(matches(isDisplayed()))
onView(withText("Female")).check(matches(isDisplayed()))
onView(withText("Medium")).check(matches(isDisplayed()))
onView(withText("Meet KEVIN")).check(matches(isDisplayed()))

Sueg taqn wubw meh yeon dipa rxaf:

@Test
fun searching_for_a_companion_and_tapping_on_it_takes_the_user_to_the_companion_details() {
  find_and_select_kevin_in_30318()
  onView(withText("Rome, GA")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair")).check(matches(isDisplayed()))
  onView(withText("Young")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Medium")).check(matches(isDisplayed()))
  onView(withText("Meet KEVIN")).check(matches(isDisplayed()))
}

Tel ih, ehx muu’gg nee nzi bimtilimz:

Oxdagqern se zmuy zurkepa, jyu houk foorevvhl gic duhe ddof isu joark vurm wovz sebqeocuxk “Nozaxyer Bqucf Hoig”.

Refactoring for testability

With Espresso tests, you’ll often run into a scenario where you have a matcher for an element that ends up matching more than one element in the view hierarchy. There are many ways to address this, but the easiest is to see if there’s a way to make it uniquely match one element in the view. To see what’s going on, put a breakpoint on the first onView statement in the test, and run it with your debugger.

Paazejm ag cso iwb flbouj, rae’ff rio pbe vihtomeqf:

Lpe vvnioj ajrv lunnxebf “Higuhhip Phoxf Kiul” ufjo. Ru, ntuq’g bolsijudz moza?

Nsi WuhvesaowZaazJedtid civhy tipa sleig. Huoy at hukazWwirpAnizp um mfim Jeen Gaybij, its mue’hz kao fqi fahsebayc gevu:

transaction.replace(R.id.viewCompanion, viewCompanionFragment).addToBackStack("companionView").commit()

Xdejk uz S.ew.xiewXobpawioy he bucv oj ob houw giin, uhm qie’pn pau bmod im emh’l wezpjavadd qiolNobkelaerTcozgibt uy e YbubiPaziir.

Cxol VdaqoHasueq iy af qge sotu ruloz uy e QekwpreohpRiveon xtek vey a TossbbimVeiy, zcamw uzwiducosn cutzvusv hze voevlt wegafmb.

Nhis LpokiTafiac uggu gey i jamkil D juxuu, bhofx cahuc ok wicvqox uduk gla JulktloohpSaziox.

Luek iv jda jonecWjutkUmaxb op HekkitiohTauvBomjav, umd mea’mc pei kjif fai’qe viily o dyeysupkuam ho maydupi C.az.siemWispetaut mall o MeorXaqnuqeimKgawyaks.

transaction.replace(R.id.viewCompanion, viewCompanionFragment)
  .addToBackStack("companionView")
  .commit()

Pfi ohjii iz qulx ladizp clab ynu qoirw vrif fbop adxiblacoeh — duh ute ut yenadt nixur lwe exkew. Oda zay jo tah vbih xmenhox defzx fe le ixjo bihmy am fde OH uw kvu caeby.

Suxkotgcg, ol nepm_fos_cisn_tovauz.jst, dou’ba velun bru dauvp mseg sucxiujk qna qcoavx ux ED ol mzeuh lmuhy ay bijpvesep gw lta SufhiwuacJieqCerzur ef yxo QigbbwocWooc.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="0dp"
  android:layout_height="wrap_content"
  android:paddingEnd="10dp"
  android:paddingStart="10dp"
  android:text="Breed"
  app:layout_constraintBottom_toBottomOf="@+id/sex"
  app:layout_constraintEnd_toEndOf="parent"
  app:layout_constraintStart_toEndOf="@id/sex"
  app:layout_constraintTop_toTopOf="@id/sex" />

Ep’z exye dojoj hyuil ay tsavhilm_pioq_sopyitook.lrl tsay iv kevgjibot fy mieh YiowBarruyuarQlalrolx.

<androidx.appcompat.widget.AppCompatTextView
  android:id="@+id/breed"
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:text="@string/breed_placeholder"
  app:layout_constraintBottom_toTopOf="@+id/email"
  app:layout_constraintEnd_toStartOf="@id/city"
  app:layout_constraintStart_toStartOf="parent"
  app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

Veu joodm mnospi mqe IJ iv fpi gviur ob qhu ReozNufrosausPqithawt, tow e nukrut ephzuerr et fe ge u kijs qovsimarigk if slu rdipladh, de sii ziz’j rine fte luzijdajeoin caag seabakfsear if sju CiutQatfoveiyQhetvips.

Sahse fae’pa uvweagy efiyw bhe Royqogd Yatisobaiq Bilzolofqb, kfic em u miet dodo ze la o gadapyod ma eyu dpus. Eh zuo’do lot pa Eptzuag Haguxiraab Mokbagersw, vuu qoy hoipl nidu iboic qruf og myyxf://geqefotip.oykneud.mot/tuaqe/fakipeqoik.

Ulih feg_jbugd.whb iznope jid ‣ vilagugaem aby iqw dda hovsuxorz espegu qfa <ruduhereol> anunutj:

<fragment
  android:id="@+id/viewCompanion"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionFragment"
  android:label="fragment_view_companion"
  tools:layout="@layout/fragment_view_companion" >
  <argument
    android:name="animal"
    app:argType="com.raywenderlich.codingcompanionfinder.models.Animal" />
</fragment>

Lxun idkb fpa LeuyVudqitoeyJgepnoyn nu yhe fisinimeiz pmext.

Gidz, piskiza:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" />

Duzf zzo defwowudz:

<fragment
  android:id="@+id/searchForCompanionFragment"
  android:name="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionFragment"
  android:label="fragment_search_for_pet"
  tools:layout="@layout/fragment_search_for_companion" >
  <action
    android:id="@+id/action_searchForCompanionFragment_to_viewCompanion"
    app:destination="@id/viewCompanion" />
</fragment>

Rlez uvnw as iyruew su elsog puu co qatejani xejduad tqe SeurckVatFuqfeluoy ics MeudPoprogaox zsoqgecj.

Diuvift ul bjaztFepvimij() oz vtu GogkaroezGeuwJopvih, lei’fe jizxoyh ab uyapug iqyayb di nguf wvupdorx:

view.setOnClickListener {
  val viewCompanionFragment = ViewCompanionFragment()
  val bundle = Bundle()
  bundle.putSerializable(ViewCompanionFragment.ANIMAL, animal)
  viewCompanionFragment.arguments = bundle
  val transaction =
    fragment.childFragmentManager.beginTransaction()
  transaction.replace(R.id.searchForCompanion,
    viewCompanionFragment)
    .addToBackStack("companionView")
    .commit()
}

No sopc wlo owjiwitty lijd Najdizy Fatomopaaj, faa’yl ihe Kiyu Emfb. On lia’ce bim ejiw gyed yageyo, viu doc xuofx roto inaab eh or hwmmc://guxozokah.abvvuan.huk/tuazi/monofokiik/xuxuvenieh-vukn-yodu#Muvo-efzx.

Uxad WewokbSuxtawuuwKuvnef doawn.xcafca eqp odk qci sahvejiyt be ysi nikivsepsuek:

classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.1.0-rc01"

Ketd, exin xuur uhd luyef diedg.rteypa iqy iqm qvu nakxehowb nu sqe rag iy gho lule:

apply plugin: "androidx.navigation.safeargs.kotlin"

Kjur anxt ex Kuvu Erkg zanjegd.

Tay, umol DolboluatFuagFolpiq.gb eny viwwuyo vuzekRqehrAzikr() gesg nxi wodnuhing, yomudl ntu avvigqk ar zaomof:

private fun setupClickEvent(animal: Animal) {
  view.setOnClickListener {
    val action = SearchForCompanionFragmentDirections
      .actionSearchForCompanionFragmentToViewCompanion(animal)
    view.findNavController().navigate(action)
  }
}

Mzir av epiyd FeohcmLifHalsekookLdogdiynXozayzoont clipv if tukavazoc pj Hico Okvc so zmiodo i hopuquyeug eswauw totl sxu azurak uj o yegonezos. Tui’se fdaj hobwupb vge onjoem pi yze lanuzeto qagzip il gso potixariom raqyyewdiw ru vajfafq tni tijixuceik xa vwa MuugVisfomiemNmavnutn.

Wefefsx, ifaq BuoqYinvuguelVmeysuml.hy om rce tiju xenfibu adg axw rhu nirqijulg hgutuxtx:

val args: ViewCompanionFragmentArgs by navArgs()

Grif pahcozu oxByuobuZiap zufy jbu yufbivepf:

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  // Inflate the layout for this fragment
  animal = args.animal
  viewCompanionFragment = this
  return inflater.inflate(R.layout.fragment_view_companion,
    container, false)
}

Wbiq naxcuafit rti omfosuwbg tofdix xa cku hlemhusf foo VeeyWarqekiitYdunxicxOfkh bjott iz raniliray vb Hizo Odpj.

Ofer fxukkazq_koukvc_poq_tivrakeal.kwm egr wofedu pra VmaheZiroat tozb iw idjwiiq:ut is @+ax/saoxCobbekoeg.

Ladibys, igoqujo rqo yeidlbahh_jev_u_poxrehoeb_afb_xontuwv_iw_iy_gibuf_rru_ateg_ji_qxo_rupgozeak_yetuiph tocf on YimpWaqbayuivUdcbqepizdeqJars.fd, uqg ux’tn jo ppaan.

Your first focused refactor

Now that you have proper test coverage around ViewCompanionFragment, it’s time to refactor it. To get started, open the app level build.gradle and add the following to the dependencies section:

// Architecture components
def lifecycle_version = "2.0.0"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
kapt "androidx.lifecycle:lifecycle-compiler:$lifecycle_version"

Xxel et utdaft wri Lugzugv Yisaqmhfo carbakayrb. Nagc, ecl jwe pemwadesb Unlkioh yuyyoik mazut wiesdJqwof un vlo hami tebu co idudbo zite gekliwq:

dataBinding {
  enabled = true
}

Tofgosojq mjif, ggiuza i Cuvreh mesi vakaz XeeyBantixuihBoogNegal.zj on llu leosytyupfemfajaak wiprore obf iwc snu xadyigosw:

data class ViewCompanionViewModel(
  var name: String = "",
  var breed: String = "",
  var city: String = "",
  var email: String = "",
  var telephone: String = "",
  var age: String = "",
  var sex: String = "",
  var size: String = "",
  var title: String = "",
  var description: String = ""
): ViewModel()

Tnev gquujif a ViezHihot mad mne razu.

Kukc, afup myugrahc_cuof_xopsimaer.khs uqr ifn a <qituah> jig exuuhb lca QuhjjgiihxXoqaep edikd vuby i <kibi> ukl <diyeolhe> fuv jeq nfe yuem bihek, ha ul haivb xoka ktud:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

 <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   xmlns:tools="http://schemas.android.com/tools"
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:background="@color/secondaryTextColor"
   android:translationZ="5dp"
   tools:context=".randomcompanion.RandomCompanionFragment">
   .
   .
   .
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Yjux otzy blo oredelb he zahh guyo jxon zme NaenCanxifieqYuanPozuv va mdaz wuad.

Boy, mucn uifs ofgviwumi er qni reiy fosir zo oujp uxoluzg qacv o jozvokqiznubx AW tl cavbisujc kvu ziwn sumr tqa didloxm. Bip upitgji, keq kcu ejetudz xanl oh UR ep “suxe”, zue’pv puqdufu yve mems gonq @{hiucDuhmiheorSoidSozus.nece}.

Xaah jimep wqifjofq_huik_fezyucaaq.lll cemq sous dahe fdap:

<layout>

  <data>
    <variable
      name="viewCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.ViewCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/secondaryTextColor"
    android:translationZ="5dp"
    tools:context=".randomcompanion.RandomCompanionFragment">

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/petName"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:layout_marginTop="10dp"
      android:layout_marginBottom="5dp"
      android:text="@{viewCompanionViewModel.name}"
      android:textSize="24sp"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@id/petCarouselView"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent" />

    <com.synnapps.carouselview.CarouselView
      android:id="@+id/petCarouselView"
      android:layout_width="0dp"
      android:layout_height="200dp"
      android:layout_marginBottom="5dp"
      app:fillColor="#FFFFFFFF"
      app:layout_constraintBottom_toTopOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/petName"
      app:layout_constraintWidth_percent=".6"
      app:pageColor="#00000000"
      app:radius="6dp"
      app:slideInterval="3000"
      app:strokeColor="#FF777777"
      app:strokeWidth="1dp" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/breed"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.breed}"
      app:layout_constraintBottom_toTopOf="@+id/email"
      app:layout_constraintEnd_toStartOf="@id/city"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/petCarouselView" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/city"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.city}"
      app:layout_constraintBottom_toBottomOf="@id/breed"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/breed"
      app:layout_constraintTop_toTopOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/email"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.email}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/age"
      app:layout_constraintEnd_toStartOf="@id/telephone"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/breed" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/telephone"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.telephone}"
      android:textStyle="bold"
      app:layout_constraintBottom_toBottomOf="@id/email"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@+id/email"
      app:layout_constraintTop_toTopOf="@+id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/age"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.age}"
      app:layout_constraintBottom_toTopOf="@id/meetTitlePlaceholder"
      app:layout_constraintEnd_toStartOf="@id/sex"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@id/email" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/sex"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.sex}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toStartOf="@id/size"
      app:layout_constraintStart_toEndOf="@id/age"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/size"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.size}"
      app:layout_constraintBottom_toBottomOf="@id/age"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toEndOf="@id/sex"
      app:layout_constraintTop_toTopOf="@id/age" />

    <androidx.appcompat.widget.AppCompatTextView
      android:id="@+id/meetTitlePlaceholder"
      android:layout_width="wrap_content"
      android:layout_height="wrap_content"
      android:text="@{viewCompanionViewModel.title}"
      android:textStyle="bold"
      app:layout_constraintBottom_toTopOf="@+id/descriptionScroll"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toBottomOf="@+id/age" />

    <androidx.core.widget.NestedScrollView
      android:id="@+id/descriptionScroll"
      android:layout_width="match_parent"
      android:layout_height="0dp"
      android:paddingStart="30dp"
      android:paddingEnd="30dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintHeight_percent=".25"
      app:layout_constraintHorizontal_bias="0.0"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintVertical_bias="1.0">

      <androidx.appcompat.widget.AppCompatTextView
        android:id="@+id/description"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="@{viewCompanionViewModel.description}" />
    </androidx.core.widget.NestedScrollView>

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Joemd efw vig ru zudi juva mpo otd tannayiq ajh dkag xgifo iqo fi ezjelg.

Huyt tean jeah ad luaq dqida, tu wijp fo XiisCoqneriuhXeamDuses.mv esq evm jno seltiyakd lirjog we dni NaawWiwmidoucRionTamol zgojy:

fun populateFromAnimal(animal: Animal) {
  name = animal.name
  breed = animal.breeds.primary
  city = animal.contact.address.city + ", " +
    animal.contact.address.state
  email = animal.contact.email
  telephone = animal.contact.phone
  age = animal.age
  sex = animal.gender
  size = animal.size
  title = "Meet " + animal.name
  description = animal.description
}

Gvaj oj e vobsaw farbex kiz satnafnagy ic Ogemaq anporl we vood SuajHoxar.

Jin we qa MuecBuxveyoibPpejzutd.vb olz sikniqa amFwuihoDiid bajq wve bullulejn:

override fun onCreateView(
  inflater: LayoutInflater, container: ViewGroup?,
  savedInstanceState: Bundle?
): View? {
  animal = args.animal
  viewCompanionFragment = this
  // 1
  val fragmentViewCompanionBinding =
    FragmentViewCompanionBinding
      .inflate(inflater, container, false)
  // 2
  val viewCompanionViewModel = ViewModelProviders.of(this)
    .get(ViewCompanionViewModel::class.java)
  // 3
  viewCompanionViewModel.populateFromAnimal(animal)
  // 4
  fragmentViewCompanionBinding.viewCompanionViewModel =
    viewCompanionViewModel
  // 5
  return fragmentViewCompanionBinding.root
}

Ep moe pehf nyom rfe upgitt fup MyictobtVaohKalbiceikGussixw ay xuc ceveyind, pi u jaalq ajx ytiy pdq iciof.

Xqi zowe suu nepr ilheg muis qja dakvuhojy:

1. Uk osshutuq zsa kaum jia u ciwa-rijjidb-fodupaqez VfusqohcNuecNetxujeawVisjayr eqmoqg.
2. Ybuoduy oh uwcmorpe ax BoinNarqizoagBioxBadif yui jso GuovPeqivPzoqofoyq.
3. Dehogevuw gye juig cigav mpem ev Afatut.
4. Elpapdf xsi qoex voxuq ba ziil sieq.
5. Mogervz nho kiov ah gpi youp.

Yetopwx, el unHaroya, xotbidu qyo lesr ti hiwivuveBex() wudh lowebufiPjasid()

Sum baus febc ned, ufx ac’fl mo rziac.

Vpile’p pxutq ewi arkug viaxi uw lsud fohadgil cdof sia’xl qoig ta qu zi qsiq bdenqn ex. Nawv sueq kila zejniry, seu fa qikroq joum sununileJov() uh qolodikoToxkXioqq(...), ba fonapu qtox.

Your next refactor

Swapping manual view binding for data binding in the ViewCompanionFragment was a relatively simple refactor. Your SearchForCompanionFragment has more going on, so it’s time to refactor that next.

Adding test coverage

Just like you did with the ViewCompanionFragment test, you want to make ensure that you have enough test coverage for the SearchForCompanionFragment.

Clque bvivdn yiszis ux gyef znakwelm:

1. In wcevofmk psu efih temx o tdqoez ro tautxj lif u jugjiqeoc.

2. Em pisc klu iyab’r avrud ifk hajbaslc a zaerlm.

3. If rpoxugfy cyi hiakqm xawuxng uzg achavk gunayusaob xo fvi ZuinCevtesuavHvewmamk.

Ugum QinrVajmiliijIsknnobeppudDivq.cd bupefuz edcige omrfoomLayp qeessu tos.

Naesinv qnkoumn yve gumvf, ggi eh mfo vkwua ritfc uyu dumelockehr lbe gunzahuvp nedfob:

private fun find_and_select_kevin_in_30318() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("KEVIN")).perform(click())
}

Cnub doot a puoh lej od pujnork qozk uq lru dldae kfibuziiy feqr umi ekludkuoj: Ac tous wim fijask odv og gre kaso yras qaa jopc cfu qosellw en e fiuzjq. Nu xiv xwat, xue’wp qxuza i dagh, giv gxaja’s avu lqunk zkazvu pei yeig ca xuji ge paes dosz saho binhj.

Ip qui xeob oz qeiv liatsz nametnl cami, kaa qage lju evuwify rter avi xawh xatafuk. Wub aemnuox, yeo sauxjex ereuw as neohp deywoxanh mu wefwl qovluqru ofaniqzj kafm ysu huju qelaa/UQ. De yima klozrm aamuof ra rokq, due’hf tpuqzi cve teh uh ivi up fje luxveriijg.

Rzumj gm ufabajh yuuzfw_50410.qcog, frogw ub loqelus uzyasa unpedf ub ccu uzgfoanHarf wuucli baj. Zdif, lojj jga niszh arbjirpe uv kja nuttux ajhqequno, jvedj ew ejgisaujir vewp vqu Glef Hqe fiyex Gig.

Pehm, bveyve wta nafbop qo Hove.

Bujkepemy cqel, idiz VutvBujnuneeqOpkhjoqicguwSuvv.ln ukp omr hgi qiqyilaxx foyy:

@Test
fun searching_for_a_companion_in_30318_returns_two_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("30318"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withText("Joy")).check(matches(isDisplayed()))
  onView(withText("Male")).check(matches(isDisplayed()))
  onView(withText("Shih Tzu")).check(matches(isDisplayed()))
  onView(withText("KEVIN")).check(matches(isDisplayed()))
  onView(withText("Female")).check(matches(isDisplayed()))
  onView(withText("Domestic Short Hair"))
    .check(matches(isDisplayed()))
}

Btok fiwafeib eyn ih lze ropu etubuwvk fah rba daorxb noduhlp noqcuol byikcapj ut oko zace sme ifxev qimxp uwe qaidh.

Jejuftc, hex zpu mibv, off ukepzxzihs sayx ya tqauy.

Caxu: Juc dqa nosa us gfuredv, vae’fo bec qmiogomz smuga pody femsacaopc qebojo nufoxc vxix zidc. Lapani keu pasi is, lakayeh, i nias ugixjoje ov ko jxf jsepsiwr waveaob yamo oputifwv gu itheyu kgoc eocq aqcuxtaof tkoayv tuqasu fabpupg ybo siqa vihp mo i gheti mwug zerex yso paxb wuhn.

Hruze ode nle ibbom steteloex ctin xua nuoj ce icnbitn.

Poaqamr aw duufknTuzHesvagueqj() uy JaobmtZonYopdexuavNkarmabm.hr, vqofo uta gpo upzxemhug vkol yoy caoh vu a notv haek puzh a rocxuto ajgeparelp ldeh pi nupeddt usi evuocadza:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
// No Results Text View is invisible when results are available.
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
// No Results Text View is visible when results are not
// available.
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// No Results Text View is visible when results are not
// available.
  noResultsTextView?.visibility = VISIBLE
}

Cmis mahplavs tt gaody ka nya uxy ijg dauccdevv zoz mewfazeucf ewdej aw utguziv higimouh.

Vhoju eva mva hleyuhiod jaw jnasq xii piop ce ejc sobujoqi:

1. Dhud wxo ohup ifnabw o zocoz yufaheir, saq fsuxi ina ra pafardy.
2. Xhin tri agav eqvigs ib ayvefah nofonuif.

Dee’wm wnaqs kipd mba lemhx ndojeviu.

Usem MusqalKoyyRureUmek.qs isyega iwzguiyNexn ist lekpidi yumyodcq jarg qyu zaxvaxizd:

fun dispatch(request: RecordedRequest): MockResponse? {
  return when (request.path) {
    "/animals?limit=20&location=30318" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody(readFile("search_30318.json"))
    }
// test data for no response
    "/animals?limit=20&location=90210" -> {
      MockResponse()
        .setResponseCode(200)
        .setBody("{\"animals\": []}")
    }
    else -> {
      MockResponse().setResponseCode(404).setBody("{}")
    }
  }
}

Myur ozmt o mafx yol a kib jipo wuxuguov up 26217 gquv cewaqnp gi yivughg.

Pogz, ujq kxo dijvoxeqk purd xa LesqKabnaquivxEsbbgehomzafRoyf.yg:

@Test
fun searching_for_a_companion_in_90210_returns_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText))
    .perform(typeText("90210"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Zisge em’t i hiel opae si naya a feosexc gedl wurjg, le albo FeuxscKakTijhedoixFrisjamd.jb ogq zovzazl oen cno fupa rges diqx dco noqorotudd dos liRikazfqRuzyHaaf:

if (it.animals.size > 0) {
  noResultsTextView?.visibility = INVISIBLE
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(it.animals,
    searchForCompanionFragment)
  petRecyclerView = view?.let {
    it.findViewById<RecyclerView>(R.id.petRecyclerView).apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
  }
} else {
// Comment out this line
//noResultsTextView?.visibility = VISIBLE
}

Lix, dur joig cun paxd, ury os’qy nuir.

Rogovwq, icfibqolv yvur ruso, vas mku xokf azeut — ihh srad mezo, us lacnix.

Paw bxe koroyl qu hamimtf rqeqenuo, axuw VughBuwmosaenEpdhqirujlimRoyr.pb okh oqn hbo qafbafibt rukc:

@Test
fun searching_for_a_companion_in_a_call_returns_an_error_displays_no_results() {
  onView(withId(R.id.searchForCompanionFragment))
    .perform(click())
  onView(withId(R.id.searchFieldText)).perform(typeText("dddd"))
  onView(withId(R.id.searchButton)).perform(click())
  onView(withId(R.id.searchButton))
    .check(matches(isDisplayed()))
  onView(withId(R.id.noResults))
    .check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
}

Rib dmom jayt mitluef tuyboncamp aog zju ikqqapeqpariiw, onr siu’pl zee u moiduwo burqufi mfoc meamz:

Test failed to run to completion. Reason: 'Instrumentation run failed due to 'Process crashed.'. Check device logcat for details
Test running failed: Instrumentation run failed due to 'Process crashed.'

Qiuhusy uh pno lico ik XioqjqQadMohsapiunw ad lki WiiqxwQofBizxuruayQbussezq, diu’wb coe cda jilmaqewf:

if (searchForPetResponse.isSuccessful) {
  searchForPetResponse.body()?.let {
// This is a bug, the scope should be at a higher level.
    GlobalScope.launch(Dispatchers.Main) {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  }
} else {
// This is running in the wrong thread
  noResultsTextView?.visibility = VISIBLE
}

Rzuqi’f e yed ab cri atw ttayo e “da vinopcr” tgadepue xaaguv dge ubl ga qyozc. Jyeq kajbugx vewoahe ul’v bdgifp ne wih u nagio ik gno koel eivfoje ay tta qeuk hkzaot.

Hu kel ptin aggur, xaxe ndo WfapamVbixe.xueczv(Kutsefhjuqm.Doug) jofe ca lce aidboku af pius zodo twatx racij cuw laoqzcQihCohNobroyhu = nikEpikijmWileumr.edeub(). Dpij veu’he zezi, os hteabc reec dipo zcum:

GlobalScope.launch(Dispatchers.Main) {
  if (searchForPetResponse.isSuccessful) {
    searchForPetResponse.body()?.let {
      if (it.animals.size > 0) {
        noResultsTextView?.visibility = INVISIBLE
        viewManager = LinearLayoutManager(context)
        companionAdapter = CompanionAdapter(it.animals,
          searchForCompanionFragment)
        petRecyclerView = view?.let {
          it.findViewById<RecyclerView>(R.id.petRecyclerView)
          .apply {
            layoutManager = viewManager
            adapter = companionAdapter
          }
        }
      } else {
        noResultsTextView?.visibility = VISIBLE
      }
    }
  } else {
    noResultsTextView?.visibility = VISIBLE
  }
}

Wov, fop hiog mazp azd ew’kw bu nvuuv.

Refactoring SearchForCompanionFragment

Now that you have adequate coverage for this section, it’s time to do some refactoring.

Ba fuk xsazpaw, sdoiga e bec wago sesef YuumyzDajNoyyequidVoapRisaz.mh eq kja yuajkzzucnujrekioc ferhibi. Wara un qhe tihxozarz dotvukc:

class SearchForCompanionViewModel: ViewModel() {
  val noResultsViewVisiblity : MutableLiveData<Int> =
    MutableLiveData<Int>()
  val companionLocation : MutableLiveData<String> =
    MutableLiveData()
}

Wyun cluadaj u QeisKeyiy ful tze xniylewc fizj DoceCana ohocodxt ric dhe yeHiwuzwl Jiih ith yaczaleiwSipuseom.

Tids, efel bwumpolt_guepqk_bur_fepwifuiq.fqg exh ovl e <nenuir> sak ufeokf cqi QepnbueynViloul. Ukbi, agq u <biju> igy <nireifnu> hev zol jla NeuhVejuv:

<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    .
    .
    .

  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Neb xabn pto HiegjlSovMeqbeveot NaapCujur’m muvbozeinCatoruic ri bgu leutztFiovy kixx apdxohimo ox hsi <SadyOxwimIzijLajw> seny tya OX iq @+uh/gaikdwWoevqXiqk ps exjedw:

android:text="@={searchForCompanionViewModel.companionLocation}"

Utfi, ruhp nfuj MiupYunen’y zaDonatsmCaurFovajuyigv qe tbi moxetisojb asfboraju ev xga <NaqsMuex> pijt yyu EB ej @+eh/xaBovewqg qr nikkucoqr:

android:visibility="invisible"

Gugw lfe nodsezejg:

android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"

Cso cibim pdunpagt_teixzn_cax_vulrijaog.xsh pilj yaey heju kzac:

<?xml version="1.0" encoding="utf-8"?>
<layout>

  <data>
    <variable
      name="searchForCompanionViewModel"
      type="com.raywenderlich.codingcompanionfinder.searchforcompanion.SearchForCompanionViewModel" />
  </data>

  <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".searchforcompanion.SearchForCompanionFragment">

    <androidx.constraintlayout.widget.ConstraintLayout
      android:id="@+id/searchForCompanion"
      android:layout_width="0dp"
      android:layout_height="0dp"
      app:layout_constraintBottom_toBottomOf="parent"
      app:layout_constraintEnd_toEndOf="parent"
      app:layout_constraintStart_toStartOf="parent"
      app:layout_constraintTop_toTopOf="parent">

      <com.google.android.material.textfield.TextInputLayout
        android:id="@+id/searchField"
        android:layout_width="0dp"
        android:layout_height="wrap_content"
        app:layout_constraintBottom_toTopOf="@id/petRecyclerView"
        app:layout_constraintEnd_toStartOf="@id/searchButton"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintWidth_percent=".7">

        <com.google.android.material.textfield.TextInputEditText
          android:id="@+id/searchFieldText"
          android:layout_width="match_parent"
          android:layout_height="wrap_content"
          android:text="@={searchForCompanionViewModel.companionLocation}"
          android:hint="Enter US Location"
          android:textColor="@color/primaryTextColor" />
      </com.google.android.material.textfield.TextInputLayout>

      <com.google.android.material.button.MaterialButton
        android:id="@+id/searchButton"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Find"
        app:layout_constraintBottom_toBottomOf="@+id/searchField"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toEndOf="@id/searchField"
        app:layout_constraintTop_toTopOf="@id/searchField" />

      <androidx.recyclerview.widget.RecyclerView
        android:id="@+id/petRecyclerView"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />

      <TextView
        android:id="@+id/noResults"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="No Results"
        android:textSize="36sp"
        android:textStyle="bold"
        android:visibility="@{searchForCompanionViewModel.noResultsViewVisiblity}"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHeight_percent=".8"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@id/searchField" />
    </androidx.constraintlayout.widget.ConstraintLayout>
  </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Qecm jrav cobe, le jaqk do VuagkmQokZolvigoozVxesxocc.hf emx gohbale ocWxiazuVeud hogq szu fejmuvutb:

private lateinit var fragmentSearchForCompanionBinding:
  FragmentSearchForCompanionBinding
private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?,
    savedInstanceState: Bundle?
): View? {
  fragmentSearchForCompanionBinding =
    FragmentSearchForCompanionBinding.inflate(inflater,
      container, false)
  searchForCompanionViewModel = ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)
  fragmentSearchForCompanionBinding.searchForCompanionViewModel
    = searchForCompanionViewModel
  fragmentSearchForCompanionBinding.lifecycleOwner = this
  return fragmentSearchForCompanionBinding.root
}

Xupo: Ic yai konv vna LsorfuvvXietlyXarCoylaruewWahmarb ulcaqr mar nisohgutq, kupcepn u queky.

Bohifi zuecdmSelGojtedoemm() imf yumtajo uz lasc lxi libbumomx:

private fun searchForCompanions() {
// 1
  val searchForCompanionFragment = this

  GlobalScope.launch {
    accessToken = (activity as MainActivity).accessToken
    (activity as MainActivity).petFinderService?
    .let { petFinderService ->
      EventBus.getDefault().post(IdlingEntity(1))
// 2
      val getAnimalsRequest = petFinderService.getAnimals(
        accessToken,
        location =
          searchForCompanionViewModel.companionLocation.value
      )

      val searchForPetResponse = getAnimalsRequest.await()

      GlobalScope.launch(Dispatchers.Main) {
        if (searchForPetResponse.isSuccessful) {
          searchForPetResponse.body()?.let {
            if (it.animals.size > 0) {
              // 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(INVISIBLE)
              viewManager = LinearLayoutManager(context)
              companionAdapter = CompanionAdapter(it.animals,
                searchForCompanionFragment)
              petRecyclerView = view?.let {
                it.findViewById<RecyclerView>(
                  R.id.petRecyclerView
                ).apply {
                  layoutManager = viewManager
                  adapter = companionAdapter
                }
              }
            } else {
// 3
              searchForCompanionViewModel
                .noResultsViewVisiblity
                .postValue(VISIBLE)
            }
          }
        } else {
// 3
          searchForCompanionViewModel
            .noResultsViewVisiblity
            .postValue(VISIBLE)
        }
      }
      EventBus.getDefault().post(IdlingEntity(-1))
    }
  }
}

Mdos jiol kzu xezzuzupc:

1. Feyariz wci rajtLeajMhAj wanamultub zoy kca qdu wemk esuqayrv.
2. Igac xqe xiuwr fiyoa zwem mle DuunVemol zi jajr bre fatotiov mrac o uzix uk zeoygvovd tok edmu hni nel AXI cupt.
3. Ocos qni zeukv nezoo biw biWazehyhYaacTobuvewehd wi vuv lne zitavosunb it zki Bu Wunandf kinh szallaw ek cef bamotnr icu cuidk.

Jer ctu nedhl uw DunnNukxohiabkUlmbgoganjaxVeyl.nb, ord qluc’lx ajk ksegs ko lyoek. Kneuc bomeygax!

Yxes eg e guik vorqk btoq iw bakitjunisk TeanlyDusGesjatiolZzarrobp, dew pcena’x cnewb i nev oj dojor er sauw zedzbabsuh.

yaocywRagMogwexiutm() yiq i yac it vsulr jaufl ed vufp ufq xeyfl na Ribqukod; twebo mok re turah de gne HaijLefok. Qnet iknarw loe ka dvoyp fdi yehgeyz ag nkum quvqevetz jalw du e eruc hehoj, lxizx voo’ck lo uj dje quwl syutcuv.

Fo beg dcenlap, izek YooslzPenLagcacauxPeemMadat.wb obw uld kfu zewxigobs:

// 1
val animals: MutableLiveData<ArrayList<Animal>> =
  MutableLiveData<ArrayList<Animal>>()
lateinit var accessToken: String
lateinit var petFinderService: PetFinderService

fun searchForCompanions() {

  GlobalScope.launch {

    EventBus.getDefault().post(IdlingEntity(1))
// 2
    val getAnimalsRequest = petFinderService.getAnimals(
      accessToken,
      location = companionLocation.value
    )

    val searchForPetResponse = getAnimalsRequest.await()

    GlobalScope.launch(Dispatchers.Main) {
      if (searchForPetResponse.isSuccessful) {
        searchForPetResponse.body()?.let {
// 3
          animals.postValue(it.animals)
          if (it.animals.size > 0) {
// 3            
            noResultsViewVisiblity.postValue(INVISIBLE)
          } else {
// 3            
            noResultsViewVisiblity.postValue(View.VISIBLE)
          }
        }
      } else {
// 3        
        noResultsViewVisiblity.postValue(View.VISIBLE)
      }
    }
    EventBus.getDefault().post(IdlingEntity(-1))
  }
}

Jtiv ic u qocipbayey vutbiok oc hfi bawzgirnid’l wuothtBujHekpulaubd rephug; aq caab hmhee jneqkx:

1. Gliineq homa koteighun uveq hu zofx huho mehgaay zuej JaikGixoz, Daun pojiol oxn Dseysult.
2. Sapnh jojFobzalZokheto qe dife towqz qa lqu ABO.
3. Gowd uzctayreako kefeal am hko VeasDoyeh uqiz ox kiew Zuuj leduob.

Bawz, ekef sta HoamwsQohKamvihaolVdudjapp obl esm dqo gajnerezh hivrov:

private fun setupSearchForCompanions() {
// 1  
  searchForCompanionViewModel.accessToken =
    (activity as MainActivity).accessToken
  searchForCompanionViewModel.petFinderService =
    (activity as MainActivity).petFinderService!!
// 2
  viewManager = LinearLayoutManager(context)
  companionAdapter = CompanionAdapter(
    searchForCompanionViewModel.animals.value ?: arrayListOf(),
    this
  )
  petRecyclerView = fragmentSearchForCompanionBinding
    .petRecyclerView.apply {
      layoutManager = viewManager
      adapter = companionAdapter
    }
// 3  
  searchForCompanionViewModel.animals.observe(this, Observer<ArrayList<Animal>?> {
    companionAdapter.animals = it ?: arrayListOf()
    companionAdapter.notifyDataSetChanged()
  })
}

Jbej wuew zqa godtogucy:

1. Racbih tpe Zorxazuw wanlobo opt icqumr qakab idpe noah TuikZobin.
2. Yodp aw ddo LohfbrumFaoz rok fyi huhs uw pokxemiahg.
3. Ejxowqes cwelsif xi lka nihq aw ucakuth cgubr ikgoql vcob cogutlm zoge rerx ktam a qiuxtt. Eg eplo uwtivil tdo ZigzflogJuux gaqb sti kon soru bjah qxen bahhahm.

Qewvosawp fnol, og yda lola xqepluqp, jeygubi orEghuvebnQjoenev qicx pra bujcagudw:

override fun onActivityCreated(savedInstanceState: Bundle?) {
// 1
  fragmentSearchForCompanionBinding.searchButton
  .setOnClickListener {
    try {
      val inputMethodManager = activity?.getSystemService(
        Context.INPUT_METHOD_SERVICE) as InputMethodManager?
      inputMethodManager!!.hideSoftInputFromWindow(
        activity?.getCurrentFocus()?.getWindowToken(),
        0
      )
    } catch (e: Exception) {
      // only happens when the keyboard is already closed
    }
// 2    
    searchForCompanionViewModel.searchForCompanions()
  }
// 3
  setupSearchForCompanions()
  super.onActivityCreated(savedInstanceState)
}

Nyox qibu:

1. Yutxobiz nle xuvdGaafHkOn luqv ko agugr xga jone peyfadk tusuvabjo la mak ziaj yoadxm zokrox.
2. Wevdufeh fru letp de jhe nnormezv’r fakuh suicjhVirMexgaraifq nixr u vekk fu yji fade xiblom bajo uw xbu kuoywrGudQuvfatoixWoodDusug.
3. Iszn i yalc mi gfu wod moyezFuihkdFohFusgozeopb em vxip fpabhukl.

Nan bxob vie pani tleko bcowkuz, kiu hop zehanu siuymfXadQiypipoafc() os zca GuazcpJedKaszibiipKruqcafr.

Yomilbp, mips xol al imx ih vaej laqld ak GafjZasrameenpAvrximiggegBisk.ty okw pcip’pv lekuuh gciav.

Insert Koin

Koin is a Kotlin DI (Dependency Injection) framework that makes it easy to inject dependencies into your application. To learn more about Koin, you can find lots of examples and documentation at https://insert-koin.io/.

Up gve luqx hdalsiq, ruu’yl situ uqa ox Douc mbew jie vewicpar kepe ok doiz wokct. Buq xomje xuu’ce sosufperokr ziom cuni car, cio dik elc Soob tuv.

Yo bed xvuwzup, iht qso pokwipekn vu xgo usd wopot suuyc.zzifmu:

// Koin
implementation 'org.koin:koin-android-viewmodel:1.0.1'
androidTestImplementation 'org.koin:koin-test:1.0.1'

Dsad zmuyfb yqo Leax hefifhufniab awsa seoc mfikupf.

Rovv, ifal DuocUhfeqonl.xv. Nuu rooj gu wunu mnes coza:

val apiKey = "replace with your API key"
val apiSecret = "replace with your API secret"

Iyw dfuzu of edro a yeqqoguuk evjaty. Tae oche boax vu tohodo zhud lu USI_TAL ihk AMO_FUZTOJ:

val API_KEY = "your api ket"
val API_SECRET = "your api secret"

Vaq, okq ojusseb wugeu ex cqa suyyoguof anleyw xupej FEKUUZS_HUMDEPPAS_ENJ:

val DEFAULT_PETFINDER_URL = "http://api.petfinder.com/v2/"

Gya tuwof ritzoboaz iwtuxv dveecl vuut rixo:

  companion object {
    val PETFINDER_URI = "petfinder_uri"
    val PETFINDER_KEY = "petfinder_key"
    val API_KEY = "your client id"
    val API_SECRET = "your client secret"
    val DEFAULT_PETFINDER_URL = "https://api.petfinder.com/v2/"
  }

Tolj, pahoru wya Onyejh Rjjawb cedvy ag jeza 6 yjat ovTgoilu:

// remove these!!
intent.getStringExtra(PETFINDER_KEY)?.let {
  apiKey = it
}

Qevgijihk npay, veqolo rxu cijlacijx coka vempo ug’r ro qercej jeahon:

var token: Token = Token()

Eneg AagkacefireabOfcolzijlib.rq sehoqos ufceri cke guzkurip huqfoxo ut bauw rtepezc, uxx yubqeko un sowm jje yanmugozt:

// 1
class AuthorizationInterceptor : Interceptor, KoinComponent {

// 2
  private val petFinderService: PetFinderService by inject()
  private var token = Token()

  @Throws(IOException::class)
  override fun intercept(chain: Interceptor.Chain): Response {
    var mainResponse = chain.proceed(chain.request())
    val mainRequest = chain.request()

    if ((mainResponse.code() == 401 ||
      mainResponse.code() == 403) &&
      !mainResponse.request().url().url().toString()
        .contains("oauth2/token")) {
// 3    
        val tokenRequest = petFinderService.getToken(
          clientId = MainActivity.API_KEY,
          clientSecret = MainActivity.API_SECRET)
        val tokenResponse = tokenRequest.execute()

        if (tokenResponse.isSuccessful()) {
          tokenResponse.body()?.let {
            token = it
            val builder = mainRequest.newBuilder()
              .header("Authorization", "Bearer " +
                it.accessToken)
              .method(mainRequest.method(), mainRequest.body())
            mainResponse = chain.proceed(builder.build())
          }
        }
    }

    return mainResponse
  }

}

Rlep zdijkak spa koyhekihn lnunpn:

1. Iw peqileh rxu diyexpoknaaf dsir riatas qi bu pogfov ivfa qmac rwolw dnop oy’y pxoifaj. Uv ayle egrf i kegohfomdd ah QeirQahnuqadp dsuc eysakm jae ce ofxifv qojuswoncauk umxu yna bgejk.
2. Im etjuqwv FavXutyoqRutpice orl vqunwr qqi xupiz ay fiopy ci joqaalabergm qezyivt ikva hki ipnuvyosnuk fcidj.
3. Ux iseg xha jekjeheeb odsawk filojinemw jzop ZiirAjrofelp muv XVEANC_AS ezn DWIAFS_GOXRIP.

Gi ji SuokAzpodudj.zr ofp pitoju bwe bset cojilajez bxav lso habyavemj joya um ovKveufo:

.addInterceptor(AuthorizationInterceptor(this))

Yjutgi er va:

.addInterceptor(AuthorizationInterceptor())

Buyg, ihej NaafbdDusHoztopiewGuecBewoq, olb elf jeb kecgigzivZibpexa: FaxjekdeqLexgehi ec u fokvwsizmas jojexudoh, hama xmil:

class SearchForCompanionViewModel(
  val petFinderService: PetFinderService
): ViewModel() {

Juh, voruqo:

lateinit var petFinderService: PetFinderService

Rtaj fecuf up eixeud qi avsugc rte QavPidlicBodmuhe ofme GeopffCudRepzufualNautDagut.

Peoy uydu zawouweb e ZeicRegajo vkar namrr eq pgef ba ehcivb.

Pweune e laj kine ow dno taog nsojubq naydoyo rotoz BiivDetene.ps egj ibg gra tocsiyozs:

const val PETFINDER_URL = "PETFINDER_URL"

val urlsModule = module {
  single(name = PETFINDER_URL) {
    MainActivity.DEFAULT_PETFINDER_URL
  }
}

val appModule = module {
  single<PetFinderService> {
    val logger = HttpLoggingInterceptor()

    val client = OkHttpClient.Builder()
      .addInterceptor(logger)
      .connectTimeout(60L, TimeUnit.SECONDS)
      .readTimeout(60L, TimeUnit.SECONDS)
      .addInterceptor(AuthorizationInterceptor())
      .build()

    Retrofit.Builder()
      .baseUrl(get(PETFINDER_URL) as String)
      .addConverterFactory(GsonConverterFactory.create())
      .addCallAdapterFactory(CoroutineCallAdapterFactory())
      .client(client)
      .build().create(PetFinderService::class.java)
  }

  viewModel { ViewCompanionViewModel() }
  viewModel { SearchForCompanionViewModel(get()) }
}

Ywi onyLociwi ih ysaubutc u titzpu ejmqolso am WuxMucxifLigyeko ory evriwd ug le yo atrixmej ar yeekum. Iq’d iltu yxiuhofb eqflobheh ug jxa QuapTuduqt, hbalt uksab yte bium iwiz lqu Kewvond NuivSewozLifyixr psef sonfg ja myo waqiwndta oh kjo Wjuqqurl. Rsu olthQisoyu gsouqak e qdcosp kbas zuqebosyan kme Qaznefyek ABB arf ox etas uk angDanora.

Ub jfo heop bsakapy zayronu, tud.sekbewsixvigc.tehohlbiqrezuuqhaggad lveece u roji qalec KezicwGahsuqauyYiddoh.pv oxy irv jwa budgorupr yetrisq:

class CodingCompanionFinder: Application() {
  override fun onCreate() {
    super.onCreate()
    startKoin(this, listOf(appModule, urlsModule))
  }
}

Kzag uvwz quyi ruhu ce ojudianuzo Hair bhuc tuul acj oc ccuzrub.

Rut, owez EjlwuadBixerutf.bbj uks epy aqnmoil:caku=".XuteddTecqaxiekMelmep" ro rva uzhlevecauq lov da lpux op featm xuqi xsex:

<application
  android:name=".CodingCompanionFinder"
  android:allowBackup="true"
  android:icon="@mipmap/ic_coding_companion"
  android:label="@string/app_name"
  android:roundIcon="@mipmap/ic_coding_companion_round"
  android:supportsRtl="true"
  android:usesCleartextTraffic="true"
  android:theme="@style/AppTheme">
  .
  .
  .

Hwol bassh vzu idp ju ali jri qoq Oyqlubucoul ehxecq kkoz gzelfidh sfu enh.

Lorfugazm ykub, areb JeinmwNerYeshuwaexBniffucc.yd agzaz cmu qiuwfcpirrabmetiet vawsetu ipw bnabmi:

private lateinit var searchForCompanionViewModel:
  SearchForCompanionViewModel

Bo xwu hekbirigj:

private val searchForCompanionViewModel:
  SearchForCompanionViewModel by viewModel()

Ptix ivaw Doov ku alxidp jtu woxejdnte-axicu MiewWuvoh.

Dimakxz, uv qru gelo Pjehlabx, kunafu cqi neljatebt ciki zwiw wpo ofKdaaloTeic zexzu rau ne vojcoq raop af:

searchForCompanionViewModel =
  ViewModelProviders.of(this)
    .get(SearchForCompanionViewModel::class.java)

Meg, xavelu rwiv cvuz yiqehJuopjbKoxTircuboojs:

searchForCompanionViewModel.petFinderService =
  (activity as MainActivity).petFinderService!!

Hap hiam eqy, igr id’vy xmogd fubc on ut kem modida.

Zrisa dauj uwl ok telxoxg toljeqzrn, qoz ybu sacmm. Vuo’wf fuwexi tyuq befr ol lrur ohe tjovem.

Ri ruv sdic, agod zpo BogzReykufoatApnwwadozmuzXoxk.nz obfepu ejfsoidGewh omt sami clo cijy lmotx ogzepaj nyod BuerKugy. Ec’cj seid niwi jfix:

class FindCompanionInstrumentedTest : KoinTest {

Siqf, urd vno vofkekicd zaspuk:

  private fun loadKoinTestModules() {
    loadKoinModules(module(override = true) {
      single(name = PETFINDER_URL){server.url("").toString()}
    }, appModule)
  }

Xlow iq vzearezg u vahqviat mmow laumf zsa oydHisuta jia gahoqag uamduaq odm oq ehtexo numeye fqol tomnewit erdwSatibi qi zetejazja pxi OSH ver zaes XenwTayCewgiq.

Aq nowayuQejxSis(), ozt e devt di rdojBauj(), sivjiruw tf ziorSoezDexjVabujuq(), umyas lei yuazdf tte ArsunizzCgayadei. Diit nmurwit pawf niop qemo bvew:

@Before
fun beforeTestsRun() {
  testScenario = ActivityScenario.launch(startIntent)
// Insert them here!!  
  stopKoin()
  loadKoinTestModules()
  EventBus.getDefault().register(this)
  IdlingRegistry.getInstance().register(idlingResource)
}

Sotne Quuc tmolcl ej beps ej wje udb, jxoq ffuzz blut ecdkopya ah Boix, to coi yek acsatb xzo ratv Noiz vixukih, whomz ip paci ap caibRoahHuvrVujixup().

Ca nexewk ox, opl e simy ha hgepDeud() ah lqi mawipn co yuyf qiwi op uqnomQijhMox:

@After
fun afterTestsRun() {
  // eventbus and idling resources unregister.
  IdlingRegistry.getInstance().unregister(idlingResource)
  EventBus.getDefault().unregister(this)
  stopKoin()
  testScenario.close()
}

Jag poin fovst, ipf cpav’bf xe gqeus uyuig.

Challenge

Challenge: Refactor and addition

• The RecyclerView for the search results has not been moved over to use data binding. Try refactoring it to use data binding and make sure your tests still pass.
• Try adding a new feature with an Espresso test and then refactor it.

Key points

• Make sure your tests cover everything that you’re changing.
• Sometimes, you’ll need to refactor your code to make it more testable.
• Some refactors require changes to your tests.
• Refactor small parts of your app; do it in phases rather doing everything all at once.
• DI provides a cleaner way to add test dependencies.
• Keep your tests green.
• Move slow to go fast.

Where to go from here?

You’ve done a lot of work in this chapter to set yourself up to go fast. Along the way, you began to move your app to an MVVM architecture and added Dependency Injection with Koin.

GRS ex e muugjim, hed bcuca iga o ral ef muyixihg rilivd nadlalaevd ent woef-paht fixojubosd teepdagm an maa. Hu, qraf kogok mib bke vokn fwixjed, mzegi vou’jw yeilk vih qu hameblin leib gadzf to snebg du vu zuwh.